Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate amethyst-inspector #17

Merged
merged 9 commits into from Apr 27, 2019

Conversation

Projects
None yet
2 participants
@Awpteamoose
Copy link
Contributor

commented Apr 23, 2019

Hey, I was asked if I want to take a crack at #16 and this is it.

screenshot

@khskarl khskarl self-requested a review Apr 23, 2019

@khskarl khskarl self-requested a review Apr 23, 2019

@khskarl
Copy link
Member

left a comment

[INFO][gfx_device_gl::shade] 		Uniform[0] = 'camera_position'	F32	Vector(3)
[INFO][gfx_device_gl::shade] 		Uniform[1] = 'line_width'	F32	Single
[INFO][gfx_device_gl::shade] 		Attrib[0] = "normal"	F32	Vector(3)
[INFO][gfx_device_gl::shade] 		Attrib[1] = "color"	F32	Vector(4)
[INFO][gfx_device_gl::shade] 		Attrib[2] = "position"	F32	Vector(3)
[INFO][gfx_device_gl::shade] 		Block[0] = 'VertexArgs' of size 192
[INFO][gfx_device_gl::shade] 			Element at 0	= 'proj'	F32	Matrix(ColumnMajor, 4, 4)
[INFO][gfx_device_gl::shade] 			Element at 64	= 'view'	F32	Matrix(ColumnMajor, 4, 4)
[INFO][gfx_device_gl::shade] 			Element at 128	= 'model'	F32	Matrix(ColumnMajor, 4, 4)
[DEBUG][gfx_device_gl::shade] Program 7 reflection: ProgramInfo { vertex_attributes: [AttributeVar { name: "normal", slot: 0, base_type: F32, container: Vector(3) }, AttributeVar { name: "color", slot: 1, base_type: F32, container: Vector(4) }, AttributeVar { name: "position", slot: 2, base_type: F32, container: Vector(3) }], globals: [ConstVar { name: "camera_position", location: 0, count: 1, base_type: F32, container: Vector(3) }, ConstVar { name: "line_width", location: 1, count: 1, base_type: F32, container: Single }], constant_buffers: [ConstantBufferVar { name: "VertexArgs", slot: 0, size: 192, usage: VERTEX | GEOMETRY, elements: [ConstVar { name: "proj", location: 0, count: 1, base_type: F32, container: Matrix(ColumnMajor, 4, 4) }, ConstVar { name: "view", location: 64, count: 1, base_type: F32, container: Matrix(ColumnMajor, 4, 4) }, ConstVar { name: "model", location: 128, count: 1, base_type: F32, container: Matrix(ColumnMajor, 4, 4) }] }], textures: [], unordereds: [], samplers: [], outputs: [], output_depth: false, knows_outputs: false }
[DEBUG][amethyst_renderer::pipe::effect] Creating raw constant buffers
[INFO][gfx_device_gl::factory] 	Created buffer 3
[DEBUG][amethyst_renderer::pipe::effect] Set global uniforms
[DEBUG][amethyst_renderer::pipe::effect] Process Color/Depth/Blend outputs
[DEBUG][amethyst_renderer::pipe::effect] Finished building effect
[INFO][gfx_device_gl::shade] 	Compiled shader 8
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Pipeline(Program(Vertex(CompilationFailed("ERROR: 0:1: \'\' :  version \'130\' is not supported\nERROR: 0:2: \'\' :  #version required and missing.\n"))))', src/libcore/result.rs:1009:5
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
   1: std::sys_common::backtrace::_print
   2: std::panicking::default_hook::{{closure}}
   3: std::panicking::default_hook
   4: std::panicking::rust_panic_with_hook
   5: std::panicking::continue_panic_fmt
   6: rust_begin_unwind
   7: core::panicking::panic_fmt
   8: core::result::unwrap_failed
   9: <amethyst_imgui::DrawUi as amethyst_renderer::pipe::pass::Pass>::compile
  10: <amethyst_renderer::pipe::pass::CompiledPass<P>>::compile
  11: <hetseq::list::List<(H, T)> as hetseq::functor::Functor<F>>::fmap
  12: <amethyst_renderer::pipe::stage::StageBuilder<Q>>::build
  13: <amethyst_renderer::pipe::pipe::PipelineBuilder<Q> as amethyst_renderer::pipe::pipe::PipelineBuild>::build
  14: <amethyst_renderer::system::RenderSystem<P>>::build
  15: <amethyst_renderer::bundle::RenderBundle<'c, B, P> as amethyst_core::bundle::SystemBundle<'a, 'b>>::build
  16: evolution_island::main
  17: std::rt::lang_start::{{closure}}
  18: std::panicking::try::do_call
  19: __rust_maybe_catch_panic
  20: std::rt::lang_start_internal
  21: main

I won't be merging it yet as I can't compile it on my machine.
Amethyst-imgui seems to have a shader that doesn't get along with macOS

I would investigate it but I don't have much time available right now, so maybe this weekend.

jaynus added a commit to jaynus/amethyst-imgui that referenced this pull request Apr 25, 2019

jaynus added a commit to jaynus/amethyst-imgui that referenced this pull request Apr 25, 2019

@Awpteamoose Awpteamoose force-pushed the Awpteamoose:master branch from 57ebe6d to e889ca1 Apr 25, 2019

@Awpteamoose Awpteamoose force-pushed the Awpteamoose:master branch from e889ca1 to 4aabe11 Apr 25, 2019

@khskarl khskarl merged commit 4a6454f into amethyst:master Apr 27, 2019

@khskarl khskarl referenced this pull request Apr 28, 2019

Closed

Debug menu #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.