Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating evoli to latest Amethyst master #79

Merged
merged 24 commits into from Jul 9, 2019

Conversation

@sunreef
Copy link
Collaborator

commented Jun 7, 2019

I upgraded Amethyst version to the latest master.

The game runs fine. Prefabs and code have been updated.

Some functionalities haven't been restored yet: the inspector and the amethyst-imgui are commented out for now.

@@ -76,8 +77,8 @@ impl Wander {
#[serde(deny_unknown_fields)]
pub struct CreaturePrefabData {
pub name: Option<Named>,
graphics: Option<GraphicsPrefab<Vec<PosNormTex>, ObjFormat, TextureFormat>>,
movement: Option<Movement>,
graphics: Option<GraphicsPrefab<Vec<PosNormTex>>>,

This comment has been minimized.

Copy link
@Frizi

Frizi Jun 26, 2019

Member

PosNormTex is not used by renderer now, as we've migrated to separate buffers in all builtin 3d passes. You have to use at least GraphicsPrefab<(Vec<Position>, Vec<TexCoord>)> for Flat renderer to pay attention to those objects.

This comment has been minimized.

Copy link
@sunreef

sunreef Jun 27, 2019

Author Collaborator

Thanks for the info. This fixed the rendering of the sprites.
However, now they appear upside down. Does Rendy use a different convention for axes than the previous rendering system ?

.with_depth_stencil(depth)
.into_pass(),
);
// let sprite_trans = graph_builder.add_node(

This comment has been minimized.

Copy link
@Frizi

Frizi Jun 26, 2019

Member

even if you add multiple rendergroups, those should usually be in single pass unless there is good reason to split. In just means do multiple with_group calls one after another.


let sprite = graph_builder.add_node(
SubpassBuilder::new()
.with_group(DrawFlatDesc::new().builder())

This comment has been minimized.

Copy link
@Frizi

Frizi Jun 26, 2019

Member

If you also want to render UI and sprites, add

.with_group(DrawFlat2DDesc::new().builder())
.with_group(DrawFlat2DTransparentDesc::new().builder())
.with_group(DrawUiDesc::new().builder())
Some(ClearValue::DepthStencil(ClearDepthStencil(1.0, 0))),
);

let sprite = graph_builder.add_node(

This comment has been minimized.

Copy link
@Frizi

Frizi Jun 26, 2019

Member

rename sprite to main_pass, there is no reason to even suggest splitting passes by some object type.

Cargo.toml Outdated
rand = "0.6.5"
log = "0.4.6"
amethyst-imgui = { git = "https://github.com/awpteamoose/amethyst-imgui.git", branch = "amethyst-v0.10" }
amethyst-inspector = { git = "https://github.com/awpteamoose/amethyst-inspector.git", branch = "amethyst-v0.10" }
#amethyst-imgui = { git = "https://github.com/awpteamoose/amethyst-imgui.git"}

This comment has been minimized.

Copy link
@jaynus

jaynus Jun 26, 2019

I've released 0.2 of amethyst-imgui which supports the latest master of amethyst. Inspector may not support it, but that should be an easy forward port.

@sunreef sunreef force-pushed the sunreef:globe_test branch from fbbc373 to 185bdd4 Jul 8, 2019

@sunreef sunreef merged commit 45f7fb7 into amethyst:master Jul 9, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@sunreef sunreef changed the title [WIP] Migrating evoli to latest Amethyst master Migrating evoli to latest Amethyst master Jul 9, 2019

@sunreef sunreef deleted the sunreef:globe_test branch Jul 10, 2019

@erlend-sh erlend-sh referenced this pull request Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.