New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo stdout doesn't appear until process exits #1

Closed
ebkalderon opened this Issue Jan 7, 2016 · 2 comments

Comments

@ebkalderon
Member

ebkalderon commented Jan 7, 2016

When calling any Amethyst subcommand which utilizes the cargo::call() wrapper, the output doesn't appear immediately on the screen.

This is because std::process::Command works like this by design, buffering the output until the process exits and then displays it all at once on the screen. Eventually, we need to find an alternative library or design that allows immediate display of stdout/stderr as the process runs.

I'm classifying this as a bug, as it makes the command very irritating from a UX point of view. This must be fixed before 1.0.

@ebkalderon ebkalderon added the type: bug label Jan 7, 2016

@ebkalderon ebkalderon added this to the 1.0 milestone Jan 7, 2016

@ebkalderon ebkalderon self-assigned this Jan 7, 2016

ebkalderon added a commit that referenced this issue Jan 13, 2016

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Jan 13, 2016

Member

Seems like the Command::stdout() method with Stdio::inherit() passed may fix this problem.

Member

ebkalderon commented Jan 13, 2016

Seems like the Command::stdout() method with Stdio::inherit() passed may fix this problem.

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Jan 13, 2016

Member

Commit 984d03c checks out! Closing this issue.

Member

ebkalderon commented Jan 13, 2016

Commit 984d03c checks out! Closing this issue.

@ebkalderon ebkalderon closed this Jan 13, 2016

LucioFranco pushed a commit to LucioFranco/tools that referenced this issue Mar 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment