New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`amethyst new` doesn't create `.gitignore` file #10

Closed
White-Oak opened this Issue Feb 10, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@White-Oak
Contributor

White-Oak commented Feb 10, 2016

I guess it should contain at least target folder.

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Feb 11, 2016

Member

D'oh! Thanks for reporting this. We need to add the missing .gitignore file to the new_project.zip archive, so that it can be included with amethyst new. I'd rather not add include target folder, though, since new Cargo projects don't have one by default anyway.

Member

ebkalderon commented Feb 11, 2016

D'oh! Thanks for reporting this. We need to add the missing .gitignore file to the new_project.zip archive, so that it can be included with amethyst new. I'd rather not add include target folder, though, since new Cargo projects don't have one by default anyway.

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Feb 11, 2016

Member

Scratch my previous comment. See the proposal given in issue #9 for a better potential fix.

Member

ebkalderon commented Feb 11, 2016

Scratch my previous comment. See the proposal given in issue #9 for a better potential fix.

ebkalderon added a commit that referenced this issue Feb 11, 2016

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Feb 11, 2016

Member

This has been fixed by pull request #12. Marking as resolved and closing.

Member

ebkalderon commented Feb 11, 2016

This has been fixed by pull request #12. Marking as resolved and closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment