/tools

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --release flag #19

Closed
ebkalderon opened this Issue Mar 9, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
Projects
Shipped in Build System
Milestone
  1.0
1 participant
@ebkalderon
@ebkalderon
Member

ebkalderon commented Mar 9, 2016

The subcommands build, clean, and run are supposed to optionally support the --release flag and pass it along to Cargo if given by the user. So far, none of these subcommands check for its presence at all.

Supporting release builds is very important, and therefore must be added before the 1.0 release rolls around.

Update: new doesn't support --release, but run does. Oops!

@ebkalderon ebkalderon added diff: easy type: feature pri: important labels Mar 9, 2016

@ebkalderon ebkalderon added this to the 1.0 milestone Mar 9, 2016

@LucioFranco LucioFranco referenced this issue Mar 9, 2016

Merged

Added Support for --release flag #20

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Mar 13, 2016

Member

With pull request #20, this issue has been resolved. Closing.
Member

ebkalderon commented Mar 13, 2016

With pull request #20, this issue has been resolved. Closing.

@ebkalderon ebkalderon added the status: resolved label Mar 13, 2016

@ebkalderon ebkalderon closed this Mar 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment