Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement deploy subcommand #22
Comments
ebkalderon
added
type: feature
diff: medium
pri: normal
labels
Mar 14, 2016
ebkalderon
added this to the 1.0 milestone
Mar 14, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Bad idea to keep saves in a game folder |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ebkalderon
Mar 14, 2016
Member
@White-Oak Could you please elaborate? Keep in mind that the deployed folder contains everything that should be put into the installer. Assuming that the published game is placed in C:\Program Files\<name>, where would you prefer these save files be placed instead? Perhaps in something like AppData/Roaming/mygame on Windows or ~/.mygame/ on Linux?
|
@White-Oak Could you please elaborate? Keep in mind that the deployed folder contains everything that should be put into the installer. Assuming that the published game is placed in |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
LucioFranco
Mar 14, 2016
Member
I know on mac a lot of games like EU4 put game saves in the documents folder. Like ~/Documents/Paradox/EU4/Saves etc.
|
I know on mac a lot of games like EU4 put game saves in the documents folder. Like ~/Documents/Paradox/EU4/Saves etc. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
White-Oak
Mar 14, 2016
Contributor
The common practice today is to put saves somewhere in home, On windows it is commonly ~/Documents/game_name or ~/AppData/Roaming/game_name. Moreover, on Windows 10 you are prohibited to write into Program files if you're not running from administrator, which is a bad practice.
|
The common practice today is to put saves somewhere in home, On windows it is commonly |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ebkalderon
Mar 14, 2016
Member
That makes sense. Applications should be "good citizens" regardless of the platform they are running on, so it follows that we follow their standards. How does the following scheme seem to you?
- Windows/OS X:
~/Documents/game_name/ - Linux/BSD:
~/.game_name/
In addition to these defaults, this location could also be configurable from config.yml, if people want. I can update the wiki page to reflect these changes accordingly.
|
That makes sense. Applications should be "good citizens" regardless of the platform they are running on, so it follows that we follow their standards. How does the following scheme seem to you?
In addition to these defaults, this location could also be configurable from |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
White-Oak
Mar 14, 2016
Contributor
@ebkalderon how about ~/.local/share or $XDG_DATA_HOME if it is set on Linux? Afaik, Linux games use that for saves.
|
@ebkalderon how about |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ebkalderon
Mar 14, 2016
Member
@White-Oak Sure. Let me look up the standard on XDG real quick so we can be sure we're using it right...
Edit: It looks like there is $XDG_DATA_HOME for user-specific data files and $XDG_CONFIG_HOME for user-specific config files (source). Should we select one of the two, or use both?
|
@White-Oak Sure. Let me look up the standard on XDG real quick so we can be sure we're using it right... Edit: It looks like there is |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@ebkalderon I suppose |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ogoding
Mar 16, 2016
Contributor
@ebkalderon I just saw this discussion, I'll remove the auto create of the saves directory.
|
@ebkalderon I just saw this discussion, I'll remove the auto create of the saves directory. |
added a commit
to ogoding/amethyst_tools
that referenced
this issue
Mar 16, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Should probably be closed as #23 was merged. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ogoding
Mar 28, 2016
Contributor
@ebkalderon An issue for the saved data discussion should be raised I think. I'm not sure if it should be in the engine or this repo, otherwise I'd create it myself.
|
@ebkalderon An issue for the saved data discussion should be raised I think. I'm not sure if it should be in the engine or this repo, otherwise I'd create it myself. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ebkalderon
Mar 28, 2016
Member
@ogoding I think we should create a new issue for that. I'll close this one in the meantime.
|
@ogoding I think we should create a new issue for that. I'll close this one in the meantime. |
ebkalderon commentedMar 14, 2016
See the relevant wiki page for a description of how the deployed game should look like. This issue is a dependency of #2.