New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deploy subcommand #22

Closed
ebkalderon opened this Issue Mar 14, 2016 · 12 comments

Comments

4 participants
@ebkalderon
Member

ebkalderon commented Mar 14, 2016

See the relevant wiki page for a description of how the deployed game should look like. This issue is a dependency of #2.

@White-Oak

This comment has been minimized.

Show comment
Hide comment
@White-Oak

White-Oak Mar 14, 2016

Contributor

Bad idea to keep saves in a game folder

Contributor

White-Oak commented Mar 14, 2016

Bad idea to keep saves in a game folder

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Mar 14, 2016

Member

@White-Oak Could you please elaborate? Keep in mind that the deployed folder contains everything that should be put into the installer. Assuming that the published game is placed in C:\Program Files\<name>, where would you prefer these save files be placed instead? Perhaps in something like AppData/Roaming/mygame on Windows or ~/.mygame/ on Linux?

Member

ebkalderon commented Mar 14, 2016

@White-Oak Could you please elaborate? Keep in mind that the deployed folder contains everything that should be put into the installer. Assuming that the published game is placed in C:\Program Files\<name>, where would you prefer these save files be placed instead? Perhaps in something like AppData/Roaming/mygame on Windows or ~/.mygame/ on Linux?

@LucioFranco

This comment has been minimized.

Show comment
Hide comment
@LucioFranco

LucioFranco Mar 14, 2016

Member

I know on mac a lot of games like EU4 put game saves in the documents folder. Like ~/Documents/Paradox/EU4/Saves etc.

Member

LucioFranco commented Mar 14, 2016

I know on mac a lot of games like EU4 put game saves in the documents folder. Like ~/Documents/Paradox/EU4/Saves etc.

@White-Oak

This comment has been minimized.

Show comment
Hide comment
@White-Oak

White-Oak Mar 14, 2016

Contributor

The common practice today is to put saves somewhere in home, On windows it is commonly ~/Documents/game_name or ~/AppData/Roaming/game_name. Moreover, on Windows 10 you are prohibited to write into Program files if you're not running from administrator, which is a bad practice.

Contributor

White-Oak commented Mar 14, 2016

The common practice today is to put saves somewhere in home, On windows it is commonly ~/Documents/game_name or ~/AppData/Roaming/game_name. Moreover, on Windows 10 you are prohibited to write into Program files if you're not running from administrator, which is a bad practice.

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Mar 14, 2016

Member

That makes sense. Applications should be "good citizens" regardless of the platform they are running on, so it follows that we follow their standards. How does the following scheme seem to you?

  • Windows/OS X: ~/Documents/game_name/
  • Linux/BSD: ~/.game_name/

In addition to these defaults, this location could also be configurable from config.yml, if people want. I can update the wiki page to reflect these changes accordingly.

Member

ebkalderon commented Mar 14, 2016

That makes sense. Applications should be "good citizens" regardless of the platform they are running on, so it follows that we follow their standards. How does the following scheme seem to you?

  • Windows/OS X: ~/Documents/game_name/
  • Linux/BSD: ~/.game_name/

In addition to these defaults, this location could also be configurable from config.yml, if people want. I can update the wiki page to reflect these changes accordingly.

@White-Oak

This comment has been minimized.

Show comment
Hide comment
@White-Oak

White-Oak Mar 14, 2016

Contributor

@ebkalderon how about ~/.local/share or $XDG_DATA_HOME if it is set on Linux? Afaik, Linux games use that for saves.

Contributor

White-Oak commented Mar 14, 2016

@ebkalderon how about ~/.local/share or $XDG_DATA_HOME if it is set on Linux? Afaik, Linux games use that for saves.

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Mar 14, 2016

Member

@White-Oak Sure. Let me look up the standard on XDG real quick so we can be sure we're using it right...

Edit: It looks like there is $XDG_DATA_HOME for user-specific data files and $XDG_CONFIG_HOME for user-specific config files (source). Should we select one of the two, or use both?

Member

ebkalderon commented Mar 14, 2016

@White-Oak Sure. Let me look up the standard on XDG real quick so we can be sure we're using it right...

Edit: It looks like there is $XDG_DATA_HOME for user-specific data files and $XDG_CONFIG_HOME for user-specific config files (source). Should we select one of the two, or use both?

@White-Oak

This comment has been minimized.

Show comment
Hide comment
@White-Oak

White-Oak Mar 14, 2016

Contributor

@ebkalderon I suppose DATA_HOME suits us more

Contributor

White-Oak commented Mar 14, 2016

@ebkalderon I suppose DATA_HOME suits us more

@ogoding

This comment has been minimized.

Show comment
Hide comment
@ogoding

ogoding Mar 16, 2016

Contributor

@ebkalderon I just saw this discussion, I'll remove the auto create of the saves directory.

Contributor

ogoding commented Mar 16, 2016

@ebkalderon I just saw this discussion, I'll remove the auto create of the saves directory.

ogoding added a commit to ogoding/amethyst_tools that referenced this issue Mar 16, 2016

@White-Oak

This comment has been minimized.

Show comment
Hide comment
@White-Oak

White-Oak Mar 28, 2016

Contributor

Should probably be closed as #23 was merged.

Contributor

White-Oak commented Mar 28, 2016

Should probably be closed as #23 was merged.

@ogoding

This comment has been minimized.

Show comment
Hide comment
@ogoding

ogoding Mar 28, 2016

Contributor

@ebkalderon An issue for the saved data discussion should be raised I think. I'm not sure if it should be in the engine or this repo, otherwise I'd create it myself.

Contributor

ogoding commented Mar 28, 2016

@ebkalderon An issue for the saved data discussion should be raised I think. I'm not sure if it should be in the engine or this repo, otherwise I'd create it myself.

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Mar 28, 2016

Member

@ogoding I think we should create a new issue for that. I'll close this one in the meantime.

Member

ebkalderon commented Mar 28, 2016

@ogoding I think we should create a new issue for that. I'll close this one in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment