New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move useful code out of CLI tool and into shared library #34

Closed
ebkalderon opened this Issue Apr 10, 2016 · 1 comment

Comments

@ebkalderon
Member

ebkalderon commented Apr 10, 2016

I think it might be useful to move as much code as possible out from the Amethyst build tool into an amethyst_tools library target. This has several advantages:

  • Build tool becomes thin frontend for library
  • Project management and Cargo wrapper code is reused when building future tools
  • Integration tests can be written directly in Rust without having to rely on shell scripts

The new source folder structure would look like this:

  • src/
    • bin/
      • amethyst.rs
      • <tool>.rs
    • lib.rs
    • <stuff>.rs

This issue is blocked by pull request #33, which will make this much easier to accomplish.

EDIT: Looks like this change will actually be coming together with pull request #33!

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Oct 10, 2016

Member

@amethyst/tools-devs I am no longer sure if this will be needed. If we implement proper project detection and validation in the engine, would there be a need to keep this a separate library? Why not import this functionality from the engine?

Member

ebkalderon commented Oct 10, 2016

@amethyst/tools-devs I am no longer sure if this will be needed. If we implement proper project detection and validation in the engine, would there be a need to keep this a separate library? Why not import this functionality from the engine?

@torkleyy torkleyy closed this Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment