Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMove useful code out of CLI tool and into shared library #34
Comments
ebkalderon
self-assigned this
Apr 10, 2016
ebkalderon
added
type: feature
diff: medium
pri: normal
labels
Apr 10, 2016
ebkalderon
added this to the 1.0 milestone
Apr 10, 2016
ebkalderon
referenced this issue
Jul 11, 2016
Closed
Refactor internal subcommand API for build tool #33
ebkalderon
added
the
status: in-progress
label
Jul 11, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
ebkalderon
Oct 10, 2016
Member
@amethyst/tools-devs I am no longer sure if this will be needed. If we implement proper project detection and validation in the engine, would there be a need to keep this a separate library? Why not import this functionality from the engine?
|
@amethyst/tools-devs I am no longer sure if this will be needed. If we implement proper project detection and validation in the engine, would there be a need to keep this a separate library? Why not import this functionality from the engine? |
torkleyy
closed this
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ebkalderon commentedApr 10, 2016
•
edited
Edited 1 time
-
ebkalderon
edited Jul 11, 2016 (most recent)
I think it might be useful to move as much code as possible out from the Amethyst build tool into an
amethyst_toolslibrary target. This has several advantages:The new source folder structure would look like this:
src/bin/amethyst.rs<tool>.rslib.rs<stuff>.rsThis issue is blocked by pull request #33, which will make this much easier to accomplish.EDIT: Looks like this change will actually be coming together with pull request #33!