New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo stderr only prints after stdout #7

Closed
ebkalderon opened this Issue Feb 10, 2016 · 2 comments

Comments

@ebkalderon
Member

ebkalderon commented Feb 10, 2016

The current behavior of the execute_if!() macro in the amethyst_cli tool is to print out error text (unformatted) immediately before quitting the program. Though this is perfectly fine for most cases, this can make redirected Cargo output from amethyst new, amethyst build, amethyst run, etc. print out at the wrong times, and also lacking colorization.

A likely solution would be to make the Cargo stderr print out alongside the stdout using an approach similar to that used to resolve issue #1. We can then have execute_if!() print out any amethyst_cli specific errors, like compressing resources and the like.

@ebkalderon ebkalderon self-assigned this Feb 10, 2016

@ebkalderon ebkalderon added this to the 1.0 milestone Feb 10, 2016

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Feb 11, 2016

Member

Unfortunately, I can't find an equivalent to std::process::Stdio::inherit() that works with stderr output. If anyone knows of a good alternative, please mention it here.

Member

ebkalderon commented Feb 11, 2016

Unfortunately, I can't find an equivalent to std::process::Stdio::inherit() that works with stderr output. If anyone knows of a good alternative, please mention it here.

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Feb 11, 2016

Member

Fixed by pull request #11. Closing.

Member

ebkalderon commented Feb 11, 2016

Fixed by pull request #11. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment