Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up`amethyst new` doesn't put authors in Cargo.toml #9
Comments
White-Oak
changed the title from
`amethyst new` doesnt put authors in Cargo.toml
to
`amethyst new` doesn't put authors in Cargo.toml
Feb 10, 2016
ebkalderon
added
type: bug
diff: hard
pri: normal
labels
Feb 11, 2016
ebkalderon
added this to the 1.0 milestone
Feb 11, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ebkalderon
Feb 11, 2016
Member
We may be able to work around manual manipulation of the TOML text. I propose the following:
- Only the
srcandresourcesdirectories remain in the "new_project.zip" file. - At runtime,
amethyst new [name]callscargo new [name]. A fresh Cargo project is created. - The contents of "new_project.zip" are unzipped into the newly-created folder.
- The
[dependencies]details are appended to the end of the "Cargo.toml" file.
Does that seem reasonable to you?
|
We may be able to work around manual manipulation of the TOML text. I propose the following:
Does that seem reasonable to you? |
This was referenced Feb 11, 2016
ebkalderon
added
diff: easy
and removed
diff: hard
labels
Feb 11, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Yes, it is a much better and easier approach! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ebkalderon
Feb 11, 2016
Member
Cool! I can get started working on it a bit later today, though if you're impatient and would like to submit a pull request sooner, I welcome it.
|
Cool! I can get started working on it a bit later today, though if you're impatient and would like to submit a pull request sooner, I welcome it. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
White-Oak
Feb 11, 2016
Contributor
@ebkalderon yeah, I would like to submit a pull request if you don't mind :)
|
@ebkalderon yeah, I would like to submit a pull request if you don't mind :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@White-Oak Please, go right ahead. |
added a commit
that referenced
this issue
Feb 11, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ebkalderon
Feb 11, 2016
Member
This has been fixed by pull request #12. Marking as resolved and closing.
|
This has been fixed by pull request #12. Marking as resolved and closing. |
White-Oak commentedFeb 10, 2016
It is probably not so easy, but I think it is possible to get git name and email on a system and add put them into
authorfield of Cargo.toml.