New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`amethyst new` doesn't put authors in Cargo.toml #9

Closed
White-Oak opened this Issue Feb 10, 2016 · 6 comments

Comments

2 participants
@White-Oak
Contributor

White-Oak commented Feb 10, 2016

It is probably not so easy, but I think it is possible to get git name and email on a system and add put them into author field of Cargo.toml.

@White-Oak White-Oak changed the title from `amethyst new` doesnt put authors in Cargo.toml to `amethyst new` doesn't put authors in Cargo.toml Feb 10, 2016

@ebkalderon ebkalderon added this to the 1.0 milestone Feb 11, 2016

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Feb 11, 2016

Member

Note: This proposal will also solve issues #8 and #10.

We may be able to work around manual manipulation of the TOML text. I propose the following:

  1. Only the src and resources directories remain in the "new_project.zip" file.
  2. At runtime, amethyst new [name] calls cargo new [name]. A fresh Cargo project is created.
  3. The contents of "new_project.zip" are unzipped into the newly-created folder.
  4. The [dependencies] details are appended to the end of the "Cargo.toml" file.

Does that seem reasonable to you?

Member

ebkalderon commented Feb 11, 2016

Note: This proposal will also solve issues #8 and #10.

We may be able to work around manual manipulation of the TOML text. I propose the following:

  1. Only the src and resources directories remain in the "new_project.zip" file.
  2. At runtime, amethyst new [name] calls cargo new [name]. A fresh Cargo project is created.
  3. The contents of "new_project.zip" are unzipped into the newly-created folder.
  4. The [dependencies] details are appended to the end of the "Cargo.toml" file.

Does that seem reasonable to you?

@White-Oak

This comment has been minimized.

Show comment
Hide comment
@White-Oak

White-Oak Feb 11, 2016

Contributor

Yes, it is a much better and easier approach!

Contributor

White-Oak commented Feb 11, 2016

Yes, it is a much better and easier approach!

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Feb 11, 2016

Member

Cool! I can get started working on it a bit later today, though if you're impatient and would like to submit a pull request sooner, I welcome it. 😉

Member

ebkalderon commented Feb 11, 2016

Cool! I can get started working on it a bit later today, though if you're impatient and would like to submit a pull request sooner, I welcome it. 😉

@White-Oak

This comment has been minimized.

Show comment
Hide comment
@White-Oak

White-Oak Feb 11, 2016

Contributor

@ebkalderon yeah, I would like to submit a pull request if you don't mind :)

Contributor

White-Oak commented Feb 11, 2016

@ebkalderon yeah, I would like to submit a pull request if you don't mind :)

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Feb 11, 2016

Member

@White-Oak Please, go right ahead. 😄

Member

ebkalderon commented Feb 11, 2016

@White-Oak Please, go right ahead. 😄

ebkalderon added a commit that referenced this issue Feb 11, 2016

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Feb 11, 2016

Member

This has been fixed by pull request #12. Marking as resolved and closing.

Member

ebkalderon commented Feb 11, 2016

This has been fixed by pull request #12. Marking as resolved and closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment