/tools

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check of exit status for `new` #14

Merged
merged 1 commit into from Feb 12, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@White-Oak @ebkalderon
@White-Oak
Contributor

White-Oak commented Feb 11, 2016

Previously tests.sh didn't check if amethyst new exited successfully, this is why #12 was passing on CI.

@White-Oak White-Oak referenced this pull request Feb 11, 2016

Closed

Expose Cargo exit status if non-zero #13

ebkalderon added a commit that referenced this pull request Feb 12, 2016

@ebkalderon
Merge pull request #14 from White-Oak/master 
added check of exit status for `new`
06e9b0b

@ebkalderon ebkalderon merged commit 06e9b0b into amethyst:master Feb 12, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Feb 12, 2016

Member

Looks good to me! Merged.
Member

ebkalderon commented Feb 12, 2016

Looks good to me! Merged.

@ebkalderon ebkalderon referenced this pull request Feb 13, 2016

Merged

Expose cargo failures #15

ebkalderon added a commit that referenced this pull request Mar 9, 2016

@ebkalderon
Add missing change log entry for PR #14
d874feb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment