Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfix for bad file descriptor error for new command #18
Conversation
LucioFranco
added some commits
Mar 6, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ebkalderon
Mar 7, 2016
Member
Looks great! Thanks for the fixes. Sorry for the delayed response, BTW. I'm running into tough times with university and work, so fixes like these are greatly appreciated.
|
Looks great! Thanks for the fixes. Sorry for the delayed response, BTW. I'm running into tough times with university and work, so fixes like these are greatly appreciated. |
added a commit
that referenced
this pull request
Mar 7, 2016
ebkalderon
merged commit b3a8117
into
amethyst:master
Mar 7, 2016
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
LucioFranco
Mar 8, 2016
Member
@ebkalderon I completely understand and in the same situation! I will definitely look to help more with this project. Good luck with school and work!
|
@ebkalderon I completely understand and in the same situation! I will definitely look to help more with this project. Good luck with school and work! |
LucioFranco commentedMar 6, 2016
I was getting a bad file descriptor error when I tried the new command. It seems that @White-Oak forgot to add the write(true) method for OpenOptions. This fixes it for me on 1.6 and the tests.sh passes.