New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for running cli tests via cargo #21

Merged
merged 4 commits into from Mar 22, 2016

Conversation

Projects
None yet
2 participants
@LucioFranco
Member

LucioFranco commented Mar 9, 2016

Small PR to allow any user to clone the repo and run cargo test to run the tests. I didn't include this in my last PR because I did not know if you wanted this or not.

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Mar 13, 2016

Member

@LucioFranco Unfortunately, for me compiling the code and running cargo test while in the same directory as the tests.sh script gave me the following failure:

     Running target/debug/amethyst-5112309b44bf399c

running 1 test
test cli ... FAILED

failures:

---- cli stdout ----
    thread 'cli' panicked at 'assertion failed: output.status.success()', src/cli/main.rs:90
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    cli

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured

Do you have any ideas how to fix this?

Member

ebkalderon commented Mar 13, 2016

@LucioFranco Unfortunately, for me compiling the code and running cargo test while in the same directory as the tests.sh script gave me the following failure:

     Running target/debug/amethyst-5112309b44bf399c

running 1 test
test cli ... FAILED

failures:

---- cli stdout ----
    thread 'cli' panicked at 'assertion failed: output.status.success()', src/cli/main.rs:90
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    cli

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured

Do you have any ideas how to fix this?

@LucioFranco

This comment has been minimized.

Show comment
Hide comment
@LucioFranco

LucioFranco Mar 13, 2016

Member

@ebkalderon That actually means the test exited with a non-zero status because it failed on asserting if the test had passed or not. That means that the test code actually behaves like it should. So now the question is what went wrong in the tests.sh script.

Member

LucioFranco commented Mar 13, 2016

@ebkalderon That actually means the test exited with a non-zero status because it failed on asserting if the test had passed or not. That means that the test code actually behaves like it should. So now the question is what went wrong in the tests.sh script.

@LucioFranco

This comment has been minimized.

Show comment
Hide comment
@LucioFranco

LucioFranco Mar 14, 2016

Member

@ebkalderon I added some test cleanup that may have been causing you issues. It works on my mac and seems like the program ran. I also added some logging so when it does panic you can see why.

Member

LucioFranco commented Mar 14, 2016

@ebkalderon I added some test cleanup that may have been causing you issues. It works on my mac and seems like the program ran. I also added some logging so when it does panic you can see why.

@ebkalderon

This comment has been minimized.

Show comment
Hide comment
@ebkalderon

ebkalderon Mar 22, 2016

Member

@LucioFranco This pull request works for me, thanks! Merging.

Member

ebkalderon commented Mar 22, 2016

@LucioFranco This pull request works for me, thanks! Merging.

ebkalderon added a commit that referenced this pull request Mar 22, 2016

Merge pull request #21 from LucioFranco/cargo-test
Added support for running cli tests via cargo

@ebkalderon ebkalderon merged commit 65ab11a into amethyst:master Mar 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment