Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded support for running cli tests via cargo #21
Conversation
LucioFranco
added some commits
Mar 9, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ebkalderon
Mar 13, 2016
Member
@LucioFranco Unfortunately, for me compiling the code and running cargo test while in the same directory as the tests.sh script gave me the following failure:
Running target/debug/amethyst-5112309b44bf399c
running 1 test
test cli ... FAILED
failures:
---- cli stdout ----
thread 'cli' panicked at 'assertion failed: output.status.success()', src/cli/main.rs:90
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
cli
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured
Do you have any ideas how to fix this?
|
@LucioFranco Unfortunately, for me compiling the code and running
Do you have any ideas how to fix this? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
LucioFranco
Mar 13, 2016
Member
@ebkalderon That actually means the test exited with a non-zero status because it failed on asserting if the test had passed or not. That means that the test code actually behaves like it should. So now the question is what went wrong in the tests.sh script.
|
@ebkalderon That actually means the test exited with a non-zero status because it failed on asserting if the test had passed or not. That means that the test code actually behaves like it should. So now the question is what went wrong in the tests.sh script. |
LucioFranco
added some commits
Mar 14, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
LucioFranco
Mar 14, 2016
Member
@ebkalderon I added some test cleanup that may have been causing you issues. It works on my mac and seems like the program ran. I also added some logging so when it does panic you can see why.
|
@ebkalderon I added some test cleanup that may have been causing you issues. It works on my mac and seems like the program ran. I also added some logging so when it does panic you can see why. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@LucioFranco This pull request works for me, thanks! Merging. |
LucioFranco commentedMar 9, 2016
Small PR to allow any user to clone the repo and run
cargo testto run the tests. I didn't include this in my last PR because I did not know if you wanted this or not.