Check for most commands if the project is an amethyst project

[White-Oak]

A function to check if a specified project appears to be a valid amethyst project.

• Decide if is_amethyst_project should return bool or CmdResult. The latter is more convinient.
• Current implementation checks only existence of config.yml and yml parsability. Probably it should also check contents, but they are not specified by the current documentation.
• Tests
  • Fail for build command if not an amethyst project

[White-Oak]

pinging @ebkalderon for a review

[White-Oak]

pinging @ebkalderon for a review

[ebkalderon]

@White-Oak Thanks! Let me finish reviewing #23 first and I'll look at this one.

[ebkalderon]

@White-Oak Thanks! Let me finish reviewing #23 first and I'll look at this one.

[LucioFranco]

@White-Oak Should you not check if there is like a project name or something inside the yaml file?

[LucioFranco]

@White-Oak Should you not check if there is like a project name or something inside the yaml file?

[White-Oak]

@LucioFranco the template of a new project's config is

---
logging:
    file_path: "new_project.log"
    output_verbosity: medium
    logging_verbosity: debug 

display:
    brightness: 1.0
    fullscreen: false
    resolution: [1024, 768]

We will probably need some docs on that file to see what should be in it.

[White-Oak]

@LucioFranco the template of a new project's config is

---
logging:
    file_path: "new_project.log"
    output_verbosity: medium
    logging_verbosity: debug 

display:
    brightness: 1.0
    fullscreen: false
    resolution: [1024, 768]

We will probably need some docs on that file to see what should be in it.

[LucioFranco]

@White-Oak Okay maybe we can create an issue to discuss that. Besides that, I think everything here looks good!

[LucioFranco]

@White-Oak Okay maybe we can create an issue to discuss that. Besides that, I think everything here looks good!

[White-Oak]

@LucioFranco would you create one?

[White-Oak]

@LucioFranco would you create one?

[LucioFranco]

@White-Oak yeah i can do that or should I wait for us to move to the new repo?

[LucioFranco]

@White-Oak yeah i can do that or should I wait for us to move to the new repo?

[ebkalderon]

@LucioFranco From what I can understand, the rollover is seamless. Still, you can create it now and then I'll migrate, just in case.

[ebkalderon]

@LucioFranco From what I can understand, the rollover is seamless. Still, you can create it now and then I'll migrate, just in case.

[White-Oak]

Merged master and resolved conflicts. Also added check for deploy subcommand.

[White-Oak]

Merged master and resolved conflicts. Also added check for deploy subcommand.

[ebkalderon]

This looks good, guys! Let's merge.

[ebkalderon]

This looks good, guys! Let's merge.