Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shards subcommands #28

Merged
merged 8 commits into from
Mar 31, 2016
Merged

Shards subcommands #28

merged 8 commits into from
Mar 31, 2016

Conversation

White-Oak
Copy link
Contributor

Implemented add <name> and remove <name>.

Currently, they add and remove 'features' from Cargo.toml of a project.

No tests, cause not sure how to test this. Maybe try to build a project?

This is an implementation of CLI task in Shards RFC.

@ebkalderon
Copy link
Member

@White-Oak Hmm, it is too early to properly test this feature since we don't have a concrete implementation of the engine modules concept. Nor do we have any Cargo features in the engine to actually try, and we don't have a spec for zipped modules.

@White-Oak
Copy link
Contributor Author

@ebkalderon It's a part one of "modules/shards" project, featuring "features".

@ebkalderon
Copy link
Member

@White-Oak We should probably make an RFC for this, given the discussion we were all having on the general room. Implementing this properly might be an involved process.

@White-Oak
Copy link
Contributor Author

@ebkalderon Certainly. But this is "the part one" as I mentioned erlier, so apart from naming it and naming commands it wouldn't have much alternatives (:

@White-Oak White-Oak changed the title Module subcommand Shards subcommands Mar 25, 2016
@White-Oak
Copy link
Contributor Author

@ebkalderon if we agreed on CLI task in RFC for shards, this is ready to be merged.

@ebkalderon
Copy link
Member

@White-Oak It looks like there are some conflicts with this pull request? Could you please resolve them? I think this is ready to be merged. We can keep discussing specifics on the shards RFC (amethyst/amethyst#34) and iterate on this as needed.

@White-Oak
Copy link
Contributor Author

@ebkalderon sure! I'll do it asap

@White-Oak
Copy link
Contributor Author

@ebkalderon Renamed modules to shards and used amethyst add <name> as a syntax.

@ebkalderon
Copy link
Member

Sorry for the delayed response. I think this pull request is essentially done, despite our inability to effectively test it. I'll merge this now!

@ebkalderon ebkalderon merged commit 33ceccb into amethyst:master Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants