New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to .NET Core 2.0 #17

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@picadoh

picadoh commented Oct 21, 2017

The less instrusive way found for doing this was using compiler directives
to remove what's not supported in .NET Core. A csproj for .NET Core was
added with .NET Core compilation specifics.

  • Performance Counters were removed as they are not supported in .NET
    Core.
  • An assembly called SmartThreadPool.NETCore is generated
  • Changed version of assemblies to be 2.3.0, as it has no impact in the
    existing interfaces

Requirements

  • .NET Core 2.0

Build

From the root directory, build the .NET Core project.

dotnet build -c Release SmartThreadPool/SmartThreadPool.NetCore.csproj

NuGet Pack

From the root directory, generate SmartThreadPool.NetCore.2.3.0.nupkg:

dotnet pack -c Release SmartThreadPool/SmartThreadPool.NetCore.csproj

NuGet Upload

From the root directory, upload to https://www.nuget.org:

dotnet nuget push <Path to NuPkg file> -s https://api.nuget.org/v3/index.json -k <NuGet API Key>
Adding support to .NET Core 2.0
The less instrusive way found for doing this was using compiler directives
to remove what's not supported in .NET Core. A csproj for .NET Core was
added with .NET Core compilation specifics.

- Performance Counters were removed as they are not supported in .NET
Core.
- An assembly called SmartThreadPool.NETCore is generated
- Changed version of assemblies to be 2.3.0, as it has no impact in the
existing interfaces

**Requirements**

- .NET Core 2.0

**Build**

From the root directory, build the .NET Core project.

    dotnet build -c Release SmartThreadPool/SmartThreadPool.NETCore.csproj

**NuGet Pack**

From the root directory, generate SmartThreadPool.NETCore.2.3.0.nupkg:

    dotnet pack -c Release SmartThreadPool/SmartThreadPool.NETCore.csproj

**NuGet Upload**

From the root directory, upload to https://www.nuget.org:

    dotnet nuget push <Path to NuPkg file> -s https://api.nuget.org/v3/index.json -k <NuGet API Key>
@sekmenhuseyin

This comment has been minimized.

sekmenhuseyin commented May 16, 2018

nice work. can we have a merge @amibar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment