Skip to content
Browse files

[DOC] Update CONTRIBUTING.md for commit prefixes and feature flags

  • Loading branch information...
1 parent 09ddc47 commit 43d4d5ad2d9d892cdf49652cdb7e39e4de16b21e @amiel committed
Showing with 15 additions and 3 deletions.
  1. +15 −3 CONTRIBUTING.md
View
18 CONTRIBUTING.md
@@ -80,12 +80,24 @@ to know that you have a clean slate: `npm install && npm test`.
3. Add a test for your change. Only refactoring and documentation changes
require no new tests. If you are adding functionality or fixing a bug, we need
-a test!
+a test! If your change is a new feature, please
+[wrap it in a feature flag](http://emberjs.com/guides/contributing/adding-new-features/).
4. Make the test pass.
-5. Commit your changes. If your pull request fixes an issue specify it in the commit message.
-Here's an example: `git commit -m "Close #52 – Fix controller and viewbindings"`
+5. Commit your changes. Please use an appropriate commit prefix.
+If your pull request fixes an issue specify it in the commit message. Some examples:
+
+ ```
+ [DOC beta] Update CONTRIBUTING.md for commit prefixes
+ [FEATURE query-params-new] Message
+ [BUGFIX beta] Message
+ [SECURITY CVE-111-1111] Message
+ ```
+
+ For more information about commit prefixes see
+ [Robert Jacksons slides on contributing to Ember](https://speakerdeck.com/rwjblue/contributing-to-ember).
+
6. Push to your fork and submit a pull request. Please provide us with some
explanation of why you made the changes you made. For new features make sure to

0 comments on commit 43d4d5a

Please sign in to comment.
Something went wrong with that request. Please try again.