Skip to content

Amiel Martin amiel

Organizations

Carnes Media
amiel commented on pull request emberjs/ember.js#5139
Amiel Martin

Yay! Nicely done.

amiel commented on pull request emberjs/ember.js#5136
Amiel Martin

@rjackson thanks. it looks like I had a couple of other feature flag issues as well (I didn't know import and export had to live outside my conditi…

Amiel Martin
  • Amiel Martin bc428bf
    [FEATURE ember-metal-is-present]
amiel commented on pull request emberjs/ember.js#5136
Amiel Martin

oh duh, thanks

Amiel Martin
  • Amiel Martin 6f76e8b
    [FEATURE ember-metal-is-present]
amiel commented on pull request emberjs/ember.js#5136
Amiel Martin

It looks like the failure now is in defeaturify; am I doing something wrong with the feature flags?

amiel commented on pull request emberjs/ember.js#5136
Amiel Martin

hmmm, it looks like this failed at npm install :(

amiel commented on pull request emberjs/ember.js#5137
Amiel Martin

Glad to help :grinning:

Amiel Martin
Amiel Martin
  • Amiel Martin 9c1820f
    [FEATURE ember-metal-is-present]
amiel deleted branch contributing-updates at amiel/ember.js
amiel commented on pull request emberjs/ember.js#5136
Amiel Martin

Please see #5137

amiel opened pull request emberjs/ember.js#5137
Amiel Martin
[DOC] Update CONTRIBUTING.md for commit prefixes and feature flags
1 commit with 15 additions and 3 deletions
Amiel Martin
  • Amiel Martin 43d4d5a
    [DOC] Update CONTRIBUTING.md for commit prefixes and feature flags
Amiel Martin
  • Amiel Martin 0a7ddc6
    [FEATURE isPresent] Add Ember.isPresent
amiel commented on pull request emberjs/ember.js#5136
Amiel Martin

@stefanpenner Sorry about that. I looked through CONTRIBUTING.md but not http://emberjs.com/guides/contributing/adding-new-features/. Is guarding t…

amiel commented on pull request emberjs/ember.js#5136
Amiel Martin

@pangratz Thanks, I've added a test.

Amiel Martin
  • Amiel Martin 9691ff8
    [FEATURE isPresent] Add Ember.isPresent
amiel opened pull request emberjs/ember.js#5136
Amiel Martin
Add Ember.isPresent
1 commit with 52 additions and 0 deletions
Amiel Martin
Amiel Martin

@jdjkelly What have you figured out? I'm in #emberjs most days if you want to chat about it :)

amiel created branch isPresent at amiel/ember.js
Amiel Martin
Eliminate the need to create concrete views
amiel pushed to master at amiel/dotfiles
Amiel Martin
amiel commented on issue gregbell/active_admin#760
Amiel Martin

@vladCovaliov This is a problem you faced using what solution? BTW, this is what #3091 is for.

Amiel Martin

FYI Chrome has pretty good tools for javascript, and you can open SiteSwapTranslate.html directly in chrome (no server required). Another hint, if …

amiel commented on pull request JugglerRick/SiteSwapTranslator#1
Amiel Martin

The browser is a fun (and weirdly hard sometimes) system. This is neat work; keep it up!

Amiel Martin
Simplest translation form
Something went wrong with that request. Please try again.