Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComdorYamlInput, Mention.comdorYaml() and unit tests #38

Merged
merged 1 commit into from Nov 4, 2017
Merged

Conversation

amihaiemil
Copy link
Owner

@amihaiemil amihaiemil commented Nov 4, 2017

Added ComdorYamlInput which represents the .comdor.yml as InputStream read from the repo. It turns the InputStream into a YamlMapping and reads the data from there.

Also added Mention.comdorYaml() which returns the .comdor.yml of the repo where the Mention has been detected.

Added unit tests for everything.

@coveralls
Copy link

coveralls commented Nov 4, 2017

Coverage Status

Coverage increased (+1.8%) to 73.984% when pulling ee8187c on 32 into 584fcbf on master.

@amihaiemil
Copy link
Owner Author

@rultor merge it

@rultor
Copy link
Collaborator

rultor commented Nov 4, 2017

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit ee8187c into master Nov 4, 2017
@amihaiemil amihaiemil deleted the 32 branch November 4, 2017 16:29
@rultor
Copy link
Collaborator

rultor commented Nov 4, 2017

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants