New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI redesign #63
UI redesign #63
Conversation
Thank you very much for your attention to the project and for your positive assessment. I really like your design, you did a great job. Thank you! I want to change the design in version 2.0. Unfortunately, for almost half a year I could not deal with the application due to a job change, but now I can devote time to it. First, I would like to solve the technical problems that have accumulated in the errors section, but then I will gladly change the design to your version. If the opportunity presents itself, I will be very grateful to pr with the redesign. Thanks again for a great job! |
just yesterday we tried to do something similar |
Thanks for the feedback! I also modified a bit of the mock-up to change the labels, and add the pause screen and ability to record from microphone (possibly new feature? Should I open an issue?).
BTW, I also check this, nice design! Is it already the actual app (coded) or still a mock-up? |
@SeaDve Thanks for great mock-up! it looks really nice. I have only 2 remarks:
|
Thanks <3
Do you mean this? If yes, I noticed it too. Actually, it was a lot closer on the first mock-up and I didn't realize it is still that close.
Had been discussing with myself about this, I think you're right. I'll also try to think of another way to show the continuing process (other than the big icon and the red button) I will make new mock-ups about your remarks. I'll try to post them soon. Thanks for the feedback! Edit:
Nevermind, I think it's enough since we already have an indicator to show at the top bar in GNOME. Edit 2: |
Nice, I think second option with "Recording" much better. |
Okay, updated the first screenshot. |
Does menu button open preferences or menu popover? If it opens preferences, I think it's better to use corresponding icon for button. If it opens menu, which options are there in this menu? |
Don't you think it will be better to use symbolic icons for start/stop buttons instead of text? I think it will look better if both stop and pause buttons will be symbolic. |
It opens the menu popover. In the latest version, it is only 'about', but hopefully though in the future, we can move some of the options to preferences.
I'm also baffled about that. In the gnome screenshot tool, it is text, so to keep consistency I also use text. I think one of the advantage of using text is it makes the button bigger and more emphasized aside from the colors. I'll make mockups tomorrow with symbolic symbols. |
Maybe, its worth deleting the label with a path to the file, because some people dont want to show their username |
i want to implement pause option, but I am not sure about it because I don't know if gstreamer is able to do it. |
Here, what do you think about it.
I see, but I think it will be a good thing to implement in the future. By the way, is it possible to build it using GNOME Builder? I tried to, but it's giving me this error.
Does it mean that I need to update the glib package? Sorry if this might be a dumb question, I am still learning gtk. |
i was able to implement pause function literally 5 minutes ago in a test project |
Nice!
How do you test your commits? I am having trouble on building the package
with my commits.
|
I skipped the git clone since I already have it in my home folder, then:
Btw, what do you think of the design? It took me hours to change the color and the border-radius, lol. I'll send the source code? |
Excellent, thanks |
I'll ask @tim77 about submodules and write you after that |
@SeaDve i guess you downloaded ZIP with sources. If so then there is no submodules in project and that's why you can't clone submodules. You should clone all project via git exactly how this described here. |
Okay, thanks! |
Added animation yay. I rewrote most of the code since I use Gtk.Stack instead of relying on set_visible property. Screencast.from.01-25-2021.07.24.28.PM.mp4 |
it`s magnificently. Can i see source code ? I rewrote rec.py completely yesterday, now i use GstElementFactory for create pipeline.This allowed to implement pause option. |
https://github.com/SeaDve/footage-design Here, I still have to clean the code (replace the toggle button with radio button, since toggle button is pretty buggy). Add the preferences.ui for preferences/settings and fix the css to support white theme. |
I'll make a new pull request to keep it clean. I guess it's ready, only a few bugs left. |
@SeaDve I am migrating the code from the master branch to the dev branch, so it is better to direct pr there |
Is there any different changes from the master? I already try to rename the elements to match the codebase. |
I didn't any changes in widgets name |
I build it and didn't give me errors, but it seems like it is not building from the local repo? Instead, it builds with the old files? These are steps of what I did. (I'm already on folder RecApp) In the meantime, ill update the footage-design repository every time I make changes. |
did you use flatpak update com.github.amikha1lov.RecApp command? do you build through the terminal or Gnome Builder ? |
No, I didn't use flatpak update. Yes, I use builder's terminal.
…On Thu, Jan 28, 2021, 02:45 Alexey Mikhailov ***@***.***> wrote:
flatpak install com.github.amikha1lov.RecApp
did you use flatpak update com.github.amikha1lov.RecApp command? do you
build through the terminal or Gnome Builder ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APKRXTY5O76KEB72YNOU6HLS4BNNTANCNFSM4WFZMONQ>
.
|
@SeaDve did it helped you? (flatpak update com.github.amikha1lov.RecApp) |
Oh sorry, I'm pretty busy with school works today. I'll try tomorrow.
…On Thu, Jan 28, 2021, 21:26 Alexey Mikhailov ***@***.***> wrote:
@SeaDve <https://github.com/SeaDve> did it helped you? (flatpak update
com.github.amikha1lov.RecApp)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APKRXT5X6VDHFMF2KGVSGATS4FQXTANCNFSM4WFZMONQ>
.
|
It works, but it is still not working good, I still have to rename and use in the .UI file. Might take me a while. Although I have rewritten the preferences window to integrate to the main window to make it easier to migrate. Here is what It looks like. Screencast.from.01-30-2021.08.52.46.AM.mp4 |
I'll consider this in the future. |
First, thanks for this wonderful app, I have been using it in Fedora for almost a month now, very helpful. The only problem is that it seems not consistent with other GNOME apps.
I recreated this icon to match GNOME human interface guidelines. I also made a couple of mock-ups to make it more at home in GNOME (The SVG file is in the source code). If I have time soon, I'll create a pull request with the design changes.
Thanks! Would love to know your opinion.