New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lint-staged and husky integration #172

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@amilajack
Copy link
Owner

amilajack commented Feb 7, 2019

No description provided.

@@ -35,6 +35,17 @@
"test-all": "cross-env NODE_ENV=test yarn lint && yarn flow && yarn spec && yarn build",
"version": "yarn build"
},
"husky": {
"hooks": {
"pre-commit": "lint-staged && yarn test"

This comment has been minimized.

@ljharb

ljharb Feb 7, 2019

Collaborator

I strongly suggest never using husky; autoinstalling git hooks is very hostile and dangerous, which is why git itself doesn't support it. Specifically, I've had a dependency's husky quietly install git hooks inside my employer's repo - it's a massive security risk.

This comment has been minimized.

@amilajack

amilajack Feb 7, 2019

Author Owner

I had second thoughts about making this PR because of that very reason. Good call

@amilajack amilajack closed this Feb 7, 2019

@ljharb ljharb deleted the husky-integration branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment