New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aminmarashi/start_aland_islands_name_with_a #1

wants to merge 7 commits into
base: master


None yet
4 participants

aminmarashi commented Nov 27, 2018

No description provided.


This comment has been minimized.

CraigLawrence commented Nov 27, 2018

Why do you have a PR to merge into the master branch of your own repo?


This comment has been minimized.

binarytom commented Nov 28, 2018

@CraigLawrence because this is a fork of an upstream module, and we need to track the changes outside our internal copy - we'll move this PR to a binary-com fork, but that needs admin permissions on the organisation.

Show resolved Hide resolved Makefile.PL Outdated
@@ -344,7 +344,7 @@ on the CLDR data's license.
This software is copyright (c) 2014 by Fayland Lam.
This software is copyright (c) 2018 by Fayland Lam.

This comment has been minimized.


zakame Dec 4, 2018

Ditto, and note to be careful about this unless upstream really does update; perhaps better to revert this particular hunk.

This comment has been minimized.


aminmarashi Dec 4, 2018


OK, since this has been brought up before, I'll remove everything except for the version bump (but it was all due to dist.ini, not manual changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment