From 0225da149f2468d0a20e5fb831e3d76e63f830f4 Mon Sep 17 00:00:00 2001
From: aminomancer <33384265+aminomancer@users.noreply.github.com>
Date: Mon, 8 Aug 2022 04:28:17 -0700
Subject: [PATCH] update pref recommendations

---
 README.md            |  3 +-
 prefs/recommended.js | 92 ++++++++++++++++++++++++--------------------
 prefs/required.js    | 24 +++++++-----
 3 files changed, 68 insertions(+), 51 deletions(-)

diff --git a/README.md b/README.md
index ee44ccb2..5feb457c 100644
--- a/README.md
+++ b/README.md
@@ -85,13 +85,14 @@ I also recommend setting the following prefs in `about:config`. There are two pr
 | <i>browser.startup.preXulSkeletonUI</i> | Boolean | false | |
 | browser.tabs.tabMinWidth | Number | 90 | User preference, but mine is 90 |
 | browser.tabs.tabmanager.enabled | Boolean | true | Enables "all tabs menu" |
-| browser.urlbar.accessibility.tabToSearch.announceResults | Boolean | false | The following hide irritating urlbar results |
+| browser.urlbar.accessibility.tabToSearch.announceResults | Boolean | false | The following disable some urlbar results |
 | browser.urlbar.quicksuggest.enabled | Boolean | false | |
 | browser.urlbar.richSuggestions.tail | Boolean | false | |
 | browser.urlbar.searchTips | Boolean | false | |
 | browser.urlbar.suggest.quicksuggest.sponsored | Boolean | false | |
 | browser.urlbar.tabToSearch.onboard.interactionsLeft | Number | 0 | |
 | browser.urlbar.trimURLs | Boolean | false | Don't hide `http://` in the urlbar |
+| <i>browser.urlbar.groupLabels.enabled</i> | Boolean | false | Don't show urlbar result group labels like "Firefox Suggest" |
 | full-screen-api.transition-duration.enter | String | `0 0` | Remove the fade in/out transition when switching to/from fullscreen |
 | full-screen-api.transition-duration.leave | String | `0 0` | |
 | full-screen-api.warning.delay | Number | -1 | Remove the warning when switching to/from fullscreen |
diff --git a/prefs/recommended.js b/prefs/recommended.js
index 8edcf6f9..6221ece1 100644
--- a/prefs/recommended.js
+++ b/prefs/recommended.js
@@ -1,5 +1,6 @@
-// required prefs
-// disable telemetry since we're modding firefox
+////// ⚠️ REQUIRED PREFS
+
+//// disable telemetry since we're modding firefox
 user_pref("toolkit.telemetry.enabled", false);
 user_pref("browser.discovery.enabled", false);
 user_pref("app.shield.optoutstudies.enabled", false);
@@ -7,25 +8,16 @@ user_pref("datareporting.healthreport.documentServerURI", "http://%(server)s/hea
 user_pref("datareporting.healthreport.uploadEnabled", false);
 user_pref("datareporting.policy.dataSubmissionPolicyBypassNotification", true);
 user_pref("browser.crashReports.unsubmittedCheck.autoSubmit2", false);
-// allow installing the unsigned search extensions.
-// the localized search extensions currently can't be signed because of
-// https://github.com/mozilla/addons-linter/issues/3911 so to use them, we must
-// disable the signature requirement and go to about:addons > gear icon >
-// install addon from file > find the .zip file
-user_pref("xpinstall.signatures.required", false);
-user_pref("extensions.autoDisableScopes", 0);
-// eliminate some nuisances
-user_pref("browser.shell.checkDefaultBrowser", false);
-user_pref("browser.startup.homepage_override.mstone", "ignore");
-// make the theme work properly
+//// make the theme work properly
 user_pref("toolkit.legacyUserProfileCustomizations.stylesheets", true);
 user_pref("browser.proton.places-tooltip.enabled", true);
 user_pref("layout.css.moz-document.content.enabled", true);
 user_pref("layout.css.xul-box-display-values.content.enabled", true);
 user_pref("layout.css.xul-display-values.content.enabled", true);
-// eliminate the blank white window during startup
+//// eliminate the blank white window during startup
 user_pref("browser.startup.blankWindow", false);
 user_pref("browser.startup.preXulSkeletonUI", false);
+////
 // required for icons with data URLs
 user_pref("svg.context-properties.content.enabled", true);
 // required for acrylic gaussian blur
@@ -36,67 +28,89 @@ user_pref("layout.css.cached-scrollbar-styles.enabled", false);
 user_pref("ui.systemUsesDarkTheme", 1);
 // enable content dark mode
 user_pref("layout.css.prefers-color-scheme.content-override", 0);
-user_pref("browser.theme.content-theme", 0);
-user_pref("browser.theme.toolbar-theme", 0);
 // allow stylesheets to modify trees in system pages viewed in regular tabs
 user_pref("layout.css.xul-tree-pseudos.content.enabled", true);
 // allow the color-mix() CSS function
 user_pref("layout.css.color-mix.enabled", true);
 // other CSS features
 user_pref("layout.css.moz-outline-radius.enabled", true);
-// avoid native styling
+//// avoid native styling
 user_pref("browser.display.windows.non_native_menus", 1);
 user_pref("widget.content.allow-gtk-dark-theme", true);
+////
 // keep "all tabs" menu available at all times, useful for all tabs menu expansion pack
 user_pref("browser.tabs.tabmanager.enabled", true);
+// disable urlbar result group labels since we don't use them
+user_pref("browser.urlbar.groupLabels.enabled", false);
 // corresponds to the system color Highlight
 user_pref("ui.highlight", "hsl(250, 100%, 60%)");
 // Background for selected <option> elements and others
 user_pref("ui.selecteditem", "#2F3456");
 // Text color for selected <option> elements and others
 user_pref("ui.selecteditemtext", "#FFFFFFCC");
-// Tooltip colors (only relevant if userChrome.ag.css somehow fails to apply, but doesn't hurt)
+//// Tooltip colors (only relevant if userChrome.ag.css somehow fails to apply, but doesn't hurt)
 user_pref("ui.infotext", "#FFFFFF");
 user_pref("ui.infobackground", "#hsl(233, 36%, 11%)");
+////
 
-// REQUIRED on macOS
+// ⚠️ REQUIRED on macOS
 user_pref("widget.macos.native-context-menus", false);
 
-// recommended prefs
-// functionality oriented prefs
+////// ✨ RECOMMENDED PREFS
+
+//// allow installing the unsigned search extensions.
+//// the localized search extensions currently can't be signed because of
+//// https://github.com/mozilla/addons-linter/issues/3911 so to use them, we must
+//// disable the signature requirement and go to about:addons > gear icon >
+//// install addon from file > find the .zip file
+user_pref("xpinstall.signatures.required", false);
+user_pref("extensions.autoDisableScopes", 0);
+//// functionality oriented prefs
+user_pref("browser.shell.checkDefaultBrowser", false);
+user_pref("browser.startup.homepage_override.mstone", "ignore");
 user_pref("browser.display.use_system_colors", false);
 user_pref("accessibility.mouse_focuses_formcontrol", 0);
-user_pref("browser.startup.blankWindow", false);
-user_pref("browser.startup.preXulSkeletonUI", false);
 user_pref("browser.tabs.tabMinWidth", 90);
 user_pref("browser.urlbar.accessibility.tabToSearch.announceResults", false);
 user_pref("browser.urlbar.richSuggestions.tail", false);
 user_pref("browser.urlbar.searchTips", false);
 user_pref("browser.urlbar.trimURLs", false);
+// hide fullscreen enter/exit warning
 user_pref("full-screen-api.transition-duration.enter", "0 0");
 user_pref("full-screen-api.transition-duration.leave", "0 0");
 user_pref("full-screen-api.warning.delay", -1);
 user_pref("full-screen-api.warning.timeout", 0);
+// whether to show content dialogs within tabs or above tabs
 user_pref("prompts.contentPromptSubDialog", true);
+// when using the keyboard to navigate menus, skip past disabled items
 user_pref("ui.skipNavigatingDisabledMenuItem", 1);
 user_pref("ui.prefersReducedMotion", 0);
+// reduce the delay before showing submenus (e.g. History > Recently Closed Tabs)
 user_pref("ui.submenuDelay", 100);
+// the delay before a tooltip appears when hovering an element (default 300ms)
 user_pref("ui.tooltipDelay", 300);
+// should pressing the Alt key alone focus the menu bar?
 user_pref("ui.key.menuAccessKeyFocuses", false);
+// reduce update frequency
 user_pref("app.update.suppressPrompts", true);
+////
 
-// style oriented prefs
+//// style oriented prefs
 // use GTK style for in-content scrollbars
 user_pref("widget.non-native-theme.scrollbar.style", 2);
-// set the scrollbar width
+//// set the scrollbar style and width
 user_pref("widget.non-native-theme.win.scrollbar.use-system-size", false);
 user_pref("widget.non-native-theme.scrollbar.size.override", 11);
 user_pref("widget.non-native-theme.gtk.scrollbar.thumb-size", "0.818");
+//// base color scheme prefs
+user_pref("browser.theme.content-theme", 0);
+user_pref("browser.theme.toolbar-theme", 0);
 // set the default background color for color-scheme: dark. see it for example on about:blank
 user_pref("browser.display.background_color.dark", "#19191b");
+////
 // make `outline-style: auto` result in one big stroke instead of two contrasting strokes
 user_pref("widget.non-native-theme.solid-outline-style", true);
-// findbar highlight and selection colors
+//// findbar highlight and selection colors
 user_pref("ui.textHighlightBackground", "#7755FF");
 user_pref("ui.textHighlightForeground", "#FFFFFF");
 user_pref("ui.textSelectBackground", "#FFFFFF");
@@ -105,47 +119,43 @@ user_pref("ui.textSelectAttentionForeground", "#FFFFFF");
 user_pref("ui.textSelectDisabledBackground", "#7755FF");
 user_pref("ui.textSelectBackgroundAttention", "#FF3388");
 user_pref("ui.textSelectBackgroundDisabled", "#7755FF");
-// spell check style
+//// spell check style
 user_pref("ui.SpellCheckerUnderline", "#E2467A");
 user_pref("ui.SpellCheckerUnderlineStyle", 1);
-// IME style (for example when typing pinyin or hangul)
+//// IME style (for example when typing pinyin or hangul)
 user_pref("ui.IMERawInputBackground", "#000000");
 user_pref("ui.IMESelectedRawTextBackground", "#7755FF");
+////
 // about:reader dark mode
 user_pref("reader.color_scheme", "dark");
 
-// windows font settings - does nothing on macOS or linux
+//// windows font settings - does nothing on macOS or linux
 user_pref("gfx.font_rendering.cleartype_params.cleartype_level", 100);
 user_pref("gfx.font_rendering.cleartype_params.force_gdi_classic_for_families", "");
 user_pref("gfx.font_rendering.cleartype_params.force_gdi_classic_max_size", 6);
 user_pref("gfx.font_rendering.cleartype_params.pixel_structure", 1);
 user_pref("gfx.font_rendering.cleartype_params.rendering_mode", 5);
 user_pref("gfx.font_rendering.directwrite.use_gdi_table_loading", false);
+////
 
-// recommended userChrome... prefs created by the theme or scripts.
-// there are many more not included here, to allow a lot more customization.
-// these are just the ones I'm pretty certain 90% of users will want.
-// see the prefs list at https://github.com/aminomancer/uc.css.js
-
+//// recommended userChrome... prefs created by the theme or scripts. there are
+//// many more not included here, to allow a lot more customization. these are
+//// just the ones I'm pretty certain 90% of users will want. see the prefs list
+//// at https://github.com/aminomancer/uc.css.js
 user_pref("userChrome.tabs.pinned-tabs.close-buttons.disabled", true);
 user_pref("userChrome.urlbar-results.hide-help-button", true);
-
-// these are more subjective prefs, but they're important ones
-// display the all tabs menu in reverse order (newer tabs on top, like history)
+//// these are more subjective prefs, but they're important ones
+//// display the all tabs menu in reverse order (newer tabs on top, like history)
 // user_pref("userChrome.tabs.all-tabs-menu.reverse-order", true);
-
 // turn bookmarks on the toolbar into small square buttons with only icons, no text
 // user_pref("userChrome.bookmarks-toolbar.icons-only", false);
-
 // replace UI font with SF Pro, the system font for macOS.
 // recommended for all operating systems, but not required.
 // must have the fonts installed. check the repo's readme for more details.
 // user_pref("userChrome.css.mac-ui-fonts", true);
-
 // add a drop shadow on menupopup and panel elements (context menus, addons' popup panels, etc.)
 // the 8px drop shadow area around the menupopup can't be clicked through.
 // this might bother some people so it's disabled by default.
 // user_pref("userChrome.css.menupopup-shadows", true);
-
 // custom wikipedia dark mode theme
 // user_pref("userChrome.css.wikipedia.dark-theme-enabled", true);
diff --git a/prefs/required.js b/prefs/required.js
index 8145c6f8..d801b008 100644
--- a/prefs/required.js
+++ b/prefs/required.js
@@ -1,5 +1,6 @@
-// required prefs
-// disable telemetry since we're modding firefox
+////// ⚠️ REQUIRED PREFS
+
+//// disable telemetry since we're modding firefox
 user_pref("toolkit.telemetry.enabled", false);
 user_pref("browser.discovery.enabled", false);
 user_pref("app.shield.optoutstudies.enabled", false);
@@ -7,15 +8,16 @@ user_pref("datareporting.healthreport.documentServerURI", "http://%(server)s/hea
 user_pref("datareporting.healthreport.uploadEnabled", false);
 user_pref("datareporting.policy.dataSubmissionPolicyBypassNotification", true);
 user_pref("browser.crashReports.unsubmittedCheck.autoSubmit2", false);
-// make the theme work properly
+//// make the theme work properly
 user_pref("toolkit.legacyUserProfileCustomizations.stylesheets", true);
 user_pref("browser.proton.places-tooltip.enabled", true);
 user_pref("layout.css.moz-document.content.enabled", true);
 user_pref("layout.css.xul-box-display-values.content.enabled", true);
 user_pref("layout.css.xul-display-values.content.enabled", true);
-// eliminate the blank white window during startup
+//// eliminate the blank white window during startup
 user_pref("browser.startup.blankWindow", false);
 user_pref("browser.startup.preXulSkeletonUI", false);
+////
 // required for icons with data URLs
 user_pref("svg.context-properties.content.enabled", true);
 // required for acrylic gaussian blur
@@ -32,20 +34,24 @@ user_pref("layout.css.xul-tree-pseudos.content.enabled", true);
 user_pref("layout.css.color-mix.enabled", true);
 // other CSS features
 user_pref("layout.css.moz-outline-radius.enabled", true);
-// avoid native styling
+//// avoid native styling
 user_pref("browser.display.windows.non_native_menus", 1);
 user_pref("widget.content.allow-gtk-dark-theme", true);
+////
 // keep "all tabs" menu available at all times, useful for all tabs menu expansion pack
 user_pref("browser.tabs.tabmanager.enabled", true);
-// Selection background, among others
-user_pref("ui.highlight", "hsla(245, 100%, 66%, .55)");
+// disable urlbar result group labels since we don't use them
+user_pref("browser.urlbar.groupLabels.enabled", false);
+// corresponds to the system color Highlight
+user_pref("ui.highlight", "hsl(250, 100%, 60%)");
 // Background for selected <option> elements and others
 user_pref("ui.selecteditem", "#2F3456");
 // Text color for selected <option> elements and others
 user_pref("ui.selecteditemtext", "#FFFFFFCC");
-// Tooltip colors (only relevant if userChrome.ag.css somehow fails to apply, but doesn't hurt)
+//// Tooltip colors (only relevant if userChrome.ag.css somehow fails to apply, but doesn't hurt)
 user_pref("ui.infotext", "#FFFFFF");
 user_pref("ui.infobackground", "#hsl(233, 36%, 11%)");
+////
 
-// REQUIRED on macOS
+// ⚠️ REQUIRED on macOS
 user_pref("widget.macos.native-context-menus", false);