Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ph.addCookie's signature doesn't match the API docs #233

Closed
pscollins opened this issue Jan 17, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@pscollins
Copy link
Contributor

commented Jan 17, 2015

The supplied addCookie method:

 addCookie: (name, value, domain, cb=->)

doesn't match the signature in the PhantomJS API documentation:

addCookie(Cookie) {boolean}

Clearly, using a callback rather than returning a boolean is unavoidable, but it seems like there's no reason to deviate from the PhantomJS API when it's not necessary --- especially since the provided function gives you less control over the cookie that you add.

@pscollins

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2015

Hey -- this is my first commit to an open-source project, so I apologize if I've done anything wrong. I added in unit tests for the new change, and everything seems to be passing. Please let me know if anything needs to be fixed.

@amir20 amir20 closed this Jan 17, 2015

@amir20

This comment has been minimized.

Copy link
Owner

commented Jan 17, 2015

Next time put Fixes #233 in the commit message and github will automatically close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.