Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ph.addCookie's signature match the PhantomJS API docs #234

Merged
merged 4 commits into from Jan 17, 2015

Conversation

Projects
None yet
2 participants
@pscollins
Copy link
Contributor

pscollins commented Jan 17, 2015

This closes this issue: #233

@pscollins

This comment has been minimized.

Copy link
Contributor Author

pscollins commented Jan 17, 2015

This adds unit tests for the commit described in #233

@amir20

This comment has been minimized.

Copy link
Owner

amir20 commented Jan 17, 2015

Nice tests @pscollins

@amir20

This comment has been minimized.

Copy link
Owner

amir20 commented Jan 17, 2015

Merging.

amir20 added a commit that referenced this pull request Jan 17, 2015

Merge pull request #234 from pscollins/master
Make ph.addCookie's signature match the PhantomJS API docs

@amir20 amir20 merged commit 066fb91 into amir20:master Jan 17, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.