New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package has incorrect layout #15

Closed
amis92 opened this Issue Apr 12, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@amis92
Owner

amis92 commented Apr 12, 2017

Currently analyzer dll is put into lib/portable-..., should be int analyzers/dotnet/cs

Requires fixing package build - possibly solved using VS2017 SDK-style csproj with built-in nuget pack.

@amis92 amis92 added the bug label Apr 12, 2017

@amis92 amis92 self-assigned this Apr 12, 2017

@amis92 amis92 added this to the v0.1.1 milestone Apr 12, 2017

@amis92

This comment has been minimized.

Owner

amis92 commented Apr 13, 2017

When moving to SDK-style csproj with nuget pack suport, there are few issues:

  1. DevelopmentDependency needs to be specified, it's fixed but not released yet: NuGet/Home#4694

  2. dlls need to be put in analyzers/dotnet/cs - to achieve that we have to set <BuildOutputFolder>True</BuilOutputFolder>, as well as <IsTool>True</IsTool> - the second one stops pack from nesting dlls in {targetFramework} folders.

  3. Remove dependency on .NET Standard Library -probably. Needs testing and also maybe it would work if target framework was set to net451/452? If not, patching generated nuspec would be needed, possibly with inspiration from https://github.com/m0sa/NuGet.FrameworkAssemblyPacker which works around NuGet/Home#4853

amis92 added a commit that referenced this issue Apr 13, 2017

@amis92

This comment has been minimized.

Owner

amis92 commented Apr 14, 2017

Closed by c640ea7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment