Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to sdk-style csproj #17

Closed
amis92 opened this issue Apr 14, 2017 · 0 comments
Closed

Move to sdk-style csproj #17

amis92 opened this issue Apr 14, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@amis92
Copy link
Owner

@amis92 amis92 commented Apr 14, 2017

Original: #15

Initial work on branch feature/sdk-csproj

When moving to SDK-style csproj with nuget pack suport, there are few issues:

  1. DevelopmentDependency needs to be specified, it's fixed but not released yet: NuGet/Home#4694

  2. dlls need to be put in analyzers/dotnet/cs - to achieve that we have to set <BuildOutputFolder>True</BuilOutputFolder>, as well as <IsTool>True</IsTool> - the second one stops pack from nesting dlls in {targetFramework} folders.

  3. Remove dependency on .NET Standard Library -probably. Needs testing and also maybe it would work if target framework was set to net451/452? If not, patching generated nuspec would be needed, possibly with inspiration from https://github.com/m0sa/NuGet.FrameworkAssemblyPacker which works around NuGet/Home#4853

@amis92 amis92 added the enhancement label Apr 14, 2017
@amis92 amis92 added this to the Future milestone Apr 14, 2017
@amis92 amis92 modified the milestones: Future, 0.3.0 Jan 17, 2018
@amis92 amis92 self-assigned this Jan 17, 2018
@amis92 amis92 closed this Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.