/essential-vanilla-javascript-functions

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for array_unique eliminates false positives #1 #2

Merged
merged 2 commits into from Sep 21, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@trevmex @amitmerchant1990 @trevmex-comcast
@trevmex
Contributor

trevmex commented Sep 20, 2017

No description provided.

@trevmex

This comment has been minimized.

Show comment
Hide comment
@trevmex

trevmex Sep 20, 2017

Contributor

This is a fix for Issue #1
Contributor

trevmex commented Sep 20, 2017

This is a fix for Issue #1
@trevmex
Simplify the keyify inner-function 
Objects cannot have objects or arrays as keys, no need to keyify the key.
4fd7ad7

@amitmerchant1990 amitmerchant1990 merged commit 7b62fb6 into amitmerchant1990:master Sep 21, 2017

@amitmerchant1990

This comment has been minimized.

Show comment
Hide comment
@amitmerchant1990

amitmerchant1990 Sep 21, 2017

Owner

Merged. Thanks! 👍
Owner

amitmerchant1990 commented Sep 21, 2017

Merged. Thanks! 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment