From 822ba987f834985bc17b6bbf46163e449debd064 Mon Sep 17 00:00:00 2001 From: Devang-Android <76443293+Devang-Android@users.noreply.github.com> Date: Wed, 16 Mar 2022 02:48:23 +0530 Subject: [PATCH] disposables obj is not using .dispose() in onDestroy() Here instead of .dispose() we are just using clear() the list which actually still perform unnecessary changes. --- .../com/rxjava2/android/samples/ui/rxbus/RxBusActivity.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/com/rxjava2/android/samples/ui/rxbus/RxBusActivity.java b/app/src/main/java/com/rxjava2/android/samples/ui/rxbus/RxBusActivity.java index a991e5e..26dc76c 100644 --- a/app/src/main/java/com/rxjava2/android/samples/ui/rxbus/RxBusActivity.java +++ b/app/src/main/java/com/rxjava2/android/samples/ui/rxbus/RxBusActivity.java @@ -29,7 +29,7 @@ public class RxBusActivity extends AppCompatActivity { @Override protected void onDestroy() { super.onDestroy(); - disposables.clear(); // do not send event after activity has been destroyed + disposables.dispose(); // do not send event after activity has been destroyed } @Override