Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdsfree everything before return'ing #8

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@marado
Copy link
Contributor

commented Apr 9, 2019

1970df3 introduces some sds uses,
and they all seem alright. However, in two cases, they are in
situations where there's a code path that meets a 'return'. In
those cases, sdsfree must be called before return.

sdsfree everything before return'ing
1970df3 introduces some sds uses,
and they all seem alright. However, in two cases, they are in
situations where there's a code path that meets a 'return'. In
those cases, sdsfree must be called before return.
@amnuts

This comment has been minimized.

Copy link
Owner

commented Apr 10, 2019

Nice spot, thanks!

@amnuts amnuts merged commit 8b420a4 into amnuts:master Apr 10, 2019

@Uzume

This comment has been minimized.

Copy link

commented May 14, 2019

It is nice to seem some activity on this again after so little for so long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.