Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Handle lack of quotes in browser command line #69

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Conversation

amodm
Copy link
Owner

@amodm amodm commented Apr 12, 2023

It seems like in some cases, the browser command line as determined by AssocQueryStringW may not be appropriately quoted, e.g. the case here.

This PR modifies the behaviour on Windows to handle this situation, as follows:

  1. If the command line has quotes, process normally
  2. If the command line does not have quotes, keep trying spaced tokens until it feels like we've come across a valid exe (as determined by path existence), quote it, and process the revised command line.

Fixes #68

@amodm amodm merged commit b28bb9d into main Apr 12, 2023
@amodm amodm deleted the fix/issue-68 branch April 12, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Program panics on windows 10 with the message 'The system cannot find the file specified.'
1 participant