Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix error message to be less misleading #76

Merged
merged 1 commit into from
Sep 19, 2023
Merged

chore: fix error message to be less misleading #76

merged 1 commit into from
Sep 19, 2023

Conversation

RobWalt
Copy link

@RobWalt RobWalt commented Sep 19, 2023

Hi 馃憢

I'm a downstream user of this crate and I stumbled across the error message when no valid browser is found. (I only have librewolf installed and it's not caught by the defaults).

The error message is talking about setting the BROWSERS variable while the code is using the BROWSER variable.

This PR corrects the error message to be more useful.

@amodm
Copy link
Owner

amodm commented Sep 19, 2023

Ah, good find. Thanks.

@amodm amodm merged commit 318adaa into amodm:main Sep 19, 2023
9 of 10 checks passed
@amodm
Copy link
Owner

amodm commented Sep 19, 2023

Given the nature of the fix, I'm not doing a release immediately for this. Will wait a bit (2-3 weeks) to see if any other changes come through. Let me know if you feel differently.

@RobWalt RobWalt deleted the chore/fix-error-message branch September 19, 2023 20:20
@RobWalt
Copy link
Author

RobWalt commented Sep 19, 2023

Thanks for the quick reaction! 鉁

Yeah, no worries. I found an easy temporary workaround which should do the trick until you do the next release. Take your time! 鈽

@amodm
Copy link
Owner

amodm commented Oct 11, 2023

FYI, this is now released as v0.8.12. Thanks for your contribution to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants