Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial AIX enablement #79

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Initial AIX enablement #79

merged 1 commit into from
Mar 5, 2024

Conversation

ecnelises
Copy link
Contributor

No description provided.

@amodm
Copy link
Owner

amodm commented Mar 5, 2024

Thanks. I don't have access to an AIX instance. If you do, can you confirm that the current unix code works for AIX?

@ecnelises
Copy link
Contributor Author

Hi, I found this issue when building tree-sitter on AIX (one of whose subcommands depends on webbrowser to open a playground).

I'm connecting to an AIX system without graphical interface (and no usable browsers) so I can't test this crate thoroughly. AIX indeed supports X, and I went over src/unix.rs to check these are plain UNIX facilities (commands, envvar, etc.). os::tests_xdg::test_xdg_open_local_file passes.

I mark this as initial support. If someone in the future are really trying to use it in a graphical environment on AIX, I'd be glad to review.

@amodm amodm merged commit 98172a0 into amodm:main Mar 5, 2024
6 of 10 checks passed
@amodm
Copy link
Owner

amodm commented Mar 5, 2024

That works. Some of the test failures have nothing to do with this PR, so I've merged it. I'll update here when this is out as a release.

@ecnelises
Copy link
Contributor Author

Thanks!

@amodm
Copy link
Owner

amodm commented Mar 5, 2024

FYI, this is now released as v0.8.13

@hadfl hadfl mentioned this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants