-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended section on tooling #50
Conversation
Addition of content from Slack conversation.
Wasn't quite sure where it should go, but fodder for discussion. |
@amontalenti Ping :) |
Thanks for the ping/reminder here. Just got busy. Will tackle this week, I hope! |
Hey @metasim, thanks again for the ping here. So, good news and bad news. The good news is that I made a couple of commits (dc84384, a31bdcb) on this branch after reviewing this contribution based on our Slack conversation. I basically did copy edits, clarifications, addition of relevant hyperlinks, and so on. You can see the finished result here: That's the good news. The bad news is, I don't think I'm ready to merge this just yet. When I incorporated this in and then re-read the style guide, I noticed a couple of things:
I think you'll also find if you read the style guide top-to-bottom, it isn't clear whether these sections "fit" perfectly just yet. Perhaps I need to take a pass at them to remove words and move them more into the punchy style of the other sections. I also don't love the idea of going on and on for sections at a time without any code examples to "break up the wall of text" (as happens in the top half of the document prior to this addition). In any case, I'm certain something from this section will make its way into the mainline, I just would like to "sleep on it" a bit. Let me know what you think after reviewing the above link! |
Also the GitHub Markdown rich visual diff here is handy for reviewing the consolidated changes across our commits: Then click this icon for the rich diff: |
Addition of content from Slack conversation.