Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6 #29

Closed
wants to merge 2 commits into from
Closed

Issue 6 #29

wants to merge 2 commits into from

Conversation

kgboreham
Copy link
Contributor

I essentially removed a code path that was attempting to set the contents of an array (even though only one element is being accessed) to a variable which is not an array.

This code path seems to be an attempt at an optimization. This works when setting a variable to another of the same type (i.e. constant to constant or array to array). The problem is that (in this case) it neglects to see that the destination is not an array. That second path (only path after my change) should always work.

Note: It is slightly slower to do the extra code generation (~0.4s delta from 81.356s on rrt transform). This is pretty low which is why I opted to remove the code path rather than attempt to fix it with another special case.

@kgboreham
Copy link
Contributor Author

This also fixes issue #23

@scottdyer
Copy link
Contributor

closed in 255907b

@scottdyer scottdyer closed this Nov 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants