Support tags in template and stack config #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I've made stack_config INHERITABLE_PROPERTIES now override template_config .. I added a dependency on hashie for deep_merge as it's used in the specs in a similar way. |
lib/bora/stack.rb
Outdated
| # Expand Tags to key, value pairs | ||
| if @stack_config[:tags] | ||
| @stack_config[:tags] = @stack_config[:tags].collect { |k, v| { key: k, value: v } } | ||
| end |
There was a problem hiding this comment.
Mutating @stack_config doesn't feel quite right here. Creates up side effects, for example what if this method happened to be called twice? Maybe assign the result of the "select" on the next line below to a temporary var, and expand the tags on that?
|
Updated! |
|
Released as 1.6.0 |
|
Sorry - pry as a development dependency slipped in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #22 an initial implementation of tags support for stack creation.