-
Notifications
You must be signed in to change notification settings - Fork 18
Fix #53: improve dependency cycle error message #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #53: improve dependency cycle error message #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this! The new cycle representations look neat. I have some feedback on style/idioms in the code and a few opportunities to simplify things.
You should also merge |
Merged master, tests pass. |
Hmm, I wonder why CircleCI isn't running on your commits? 🤔 |
It's supposed to: Maybe @aengelberg would be willing to look in to this? :^) |
Closes #53
Error message for cyclic deps now pretty-prints all (unique) cycles in the dependency graph, from smallest to largest. I removed the
:input
map from the thrown exception, and replaced it with:cycles
, the collection of cycles in the same order as printed in the error.Example deps graph:
Example (new) error message: