Repository navigation
Fix #53: improve dependency cycle error message - #61
Merged
Merged
Conversation
greglook
suggested changes
Feb 14, 2020
greglook
left a comment
Contributor
There was a problem hiding this comment.
Thanks for tackling this! The new cycle representations look neat. I have some feedback on style/idioms in the code and a few opportunities to simplify things.
Contributor
|
You should also merge |
Contributor
Author
|
Merged master, tests pass. |
Contributor
|
Hmm, I wonder why CircleCI isn't running on your commits? 🤔 |
Contributor
It's supposed to: Maybe @aengelberg would be willing to look in to this? :^) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #53
Error message for cyclic deps now pretty-prints all (unique) cycles in the dependency graph, from smallest to largest. I removed the
:inputmap from the thrown exception, and replaced it with:cycles, the collection of cycles in the same order as printed in the error.Example deps graph:
{:a #{:b}, :b #{:c :a}, :c #{:d}, :d #{:a :b}}Example (new) error message: