Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ImagePullPolicy to Always in the student prototype template yaml #354

Closed
FranSlot opened this issue Feb 2, 2024 · 1 comment
Closed

Set ImagePullPolicy to Always in the student prototype template yaml #354

FranSlot opened this issue Feb 2, 2024 · 1 comment
Assignees
@FranSlot
Labels
bug: normal prio RAP5

Comments

@FranSlot
Copy link
Contributor

FranSlot commented Feb 2, 2024 •
edited

When updating the student prototype image the prototypes created by students don't actually use the new image if the previous version is cached. This is due to using the :latest tag in the template.
@FranSlot FranSlot self-assigned this Feb 5, 2024
FranSlot added a commit that referenced this issue Feb 6, 2024
@FranSlot
#354: Fixed the getImageCommand
5a92e83
FranSlot added a commit that referenced this issue Feb 7, 2024
@FranSlot
#354: Reverted imagepullpolicy
26876e9
@FranSlot
Copy link
Contributor Author

FranSlot commented Feb 9, 2024

Updating the pull policy is not the best solution. Instead we are making the prototype request the image of the student prototype deployment that is included to cache the image. This way it will always be the latest.

stefjoosten added a commit that referenced this issue Jul 15, 2024
@stefjoosten
Merge commit 'b0f8e06b995393d1b67037ac60c5b8d29c898c59' into names-an…
430432a 
…d-labels

* commit 'b0f8e06b995393d1b67037ac60c5b8d29c898c59':
  #372 Removed unnecessary execution permission grant
  #372 Refactored student prototype startup script
  #355: Refactor and fix crash loop.
  #356: Added explanation why we sanitise.
  #356: Forgot to add the prefix.
  #356: Added username sanitation.
  #361 added default prefix to username to prevent errors when only using numbers
  Fixed typo
  Fixes for deployment issues with prototype (newlines and chmod) documented in deployment-guide.md
  Update ExecEngineFunctions.php
  #354: Reverted imagepullpolicy
  #354: Fixed the getImageCommand
  added getimagecommand
  Added image pull policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FranSlot FranSlot

Labels
bug: normal prio RAP5
Projects
Ampersand development in VS-code
Status: Done
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/bug/354-set-imagepullpolicy-to-always-in-the-student-prototype-template-yaml AmpersandTarski/RAP
1 participant
@FranSlot