Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LimitedConnectionPool limits concurrent requests instead of concurrent connections #252

Open
nicolas-grekas opened this issue Jan 14, 2020 · 1 comment · May be fixed by #253
Open

LimitedConnectionPool limits concurrent requests instead of concurrent connections #252

nicolas-grekas opened this issue Jan 14, 2020 · 1 comment · May be fixed by #253

Comments

@nicolas-grekas
Copy link
Contributor

@nicolas-grekas nicolas-grekas commented Jan 14, 2020

LimitedConnectionPool is not compatible with multiplexing several HTTP/2 requests on a single connection. Instead, it throttles the number of streams, which looks quite counter productive :)

@kelunik kelunik changed the title LimitedConnectionPool doesn't work HTTP/2 multiplexing LimitedConnectionPool limits concurrent requests instead of concurrent connections Jan 14, 2020
@trowski

This comment has been minimized.

Copy link
Member

@trowski trowski commented Jan 14, 2020

I was working on a PR this morning, incoming soon.

@trowski trowski linked a pull request that will close this issue Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.