Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication doesn't support UserAuthBanner #18

Open
Ekstazi opened this issue Jun 18, 2019 · 5 comments

Comments

3 participants
@Ekstazi
Copy link
Collaborator

commented Jun 18, 2019

If bad credentials used and server respond with auth banner then library treat this situatiobon as success login. Also library doesn't check for service accept response when authentication protocol requested

Ekstazi added a commit to Ekstazi/ssh that referenced this issue Jun 18, 2019

@kelunik

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

@Ekstazi We currently can't keep up with this library, but we'd like to grant you direct commit access. Would you be interested in that?

/cc @trowski @joelwurtz @bwoebi

@Ekstazi

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 19, 2019

Yes

@kelunik

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

Granted! If you have questions about releases, code-style or anything, we're of course still here to help.

@joelwurtz

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

Thanks @kelunik i was going to ask this also, currently got no time for open source and @Ekstazi seems to know the subject :)

@kelunik

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

@joelwurtz Wanted to ask you, but you seemed rather inactive here recently, so skipped that. Should have probably asked you anyway, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.