Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to use newer libsodium #9

Open
wants to merge 7 commits into
base: master
from

Conversation

2 participants
@Ekstazi
Copy link
Contributor

commented May 21, 2019

attempt to fix travis build

@Ekstazi Ekstazi referenced this pull request May 21, 2019

Open

Fix travis ci build #8

Ekstazi added some commits May 21, 2019

@joelwurtz

This comment has been minimized.

Copy link
Collaborator

commented May 21, 2019

Thanks maybe it would be better to directly compile it from source: see this file for an example: https://github.com/jedisct1/libsodium-php/blob/master/.travis.yml

AFAIK libsodium from this ppa is the 1.0.3 version (see https://launchpad.net/~chris-lea/+archive/ubuntu/libsodium) so it will not fix the issue

Ekstazi added some commits May 21, 2019

@Ekstazi

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

I switched php versions to 7.2, 7.3, 7.4 and 8 because trusty doesn't support newer libsodium version. May be you can change vm image to xenial or disco ?

@Ekstazi

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

Thanks maybe it would be better to directly compile it from source: see this file for an example: https://github.com/jedisct1/libsodium-php/blob/master/.travis.yml

AFAIK libsodium from this ppa is the 1.0.3 version (see https://launchpad.net/~chris-lea/+archive/ubuntu/libsodium) so it will not fix the issue
I'll try to test it tomorrow

@Ekstazi

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

I returned back php 7.0 and 7.1. libsodium now builded from source. So i finished. Your can merge this pull request to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.