New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve undefined references #2

Merged
merged 1 commit into from Sep 2, 2014

Conversation

Projects
None yet
2 participants
@tkelman
Copy link
Contributor

tkelman commented Sep 1, 2014

fully link internal dependencies, needed for creating dll - this is the same basic issue as ampl/mp#6, found by building AMPL/MP (with my patches, sha tkelman/mp@7616a70) with -DBUILD_SHARED_LIBS:BOOL=ON -DCMAKE_SHARED_LINKER_FLAGS=-Wl,--no-undefined -DBUILD=all on Ubuntu 14.04.

@vitaut it looks like you're the author of this cmake file, can you submit this upstream if you agree with the patch? I've never used gecode before but this seems like a safe change to me.

resolve undefined references
fully link internal dependencies, needed for creating dll

vitaut added a commit that referenced this pull request Sep 2, 2014

Merge pull request #2 from tkelman/linkage
resolve undefined references

@vitaut vitaut merged commit d53d858 into ampl:master Sep 2, 2014

@tkelman tkelman deleted the tkelman:linkage branch Sep 2, 2014

@vitaut

This comment has been minimized.

Copy link
Contributor

vitaut commented Sep 2, 2014

Submitted the patch including this and other changes upstream: http://www.gecode.org/pipermail/users/2014-September/004489.html
Thanks!

@vitaut

This comment has been minimized.

Copy link
Contributor

vitaut commented Sep 3, 2014

Thanks to Christian Schulte this is in Gecode version 4.3.0 already: http://www.gecode.org/doc-latest/reference/PageChange.html#SectionChanges_4_3_0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment