New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to use expired/revoked/failed certificates when selecting cert by name #167

Merged
merged 4 commits into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@revmischa
Contributor

revmischa commented Nov 7, 2018

If you have two domains of the same name, and one is expired, we should pick the unexpired one.

revmischa added some commits Nov 7, 2018

@captainsidd

This comment has been minimized.

Contributor

captainsidd commented Nov 7, 2018

Hi there! Thanks for the PR, we'll get this merged for you.

@captainsidd captainsidd merged commit 5390fa5 into amplify-education:master Nov 7, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment