From 4e5bb3b468b6c19311b3e55bf891d0621881bcb0 Mon Sep 17 00:00:00 2001 From: John Tran Date: Mon, 21 Sep 2020 21:48:50 -0700 Subject: [PATCH 1/4] change file name --- .github/workflows/release.yml | 2 +- release.config.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 95272052..d7474acd 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -40,7 +40,7 @@ jobs: uses: actions/setup-python@v2 with: python-version: '3.8.x' - - name: Install boto3 for deployjs.python + - name: Install boto3 for deploy_s3.python run: pip install boto3==1.14.63 - name: Setup Node.js diff --git a/release.config.js b/release.config.js index d6a7d7c4..c3e85109 100644 --- a/release.config.js +++ b/release.config.js @@ -15,7 +15,7 @@ module.exports = { }], ["@semantic-release/exec", { "prepareCmd": "make release", - "publishCmd": "python scripts/deployjs.py --version ${nextRelease.version}", + "publishCmd": "python scripts/deploy_s3.py --version ${nextRelease.version}", "failCmd": "npm unpublish amplitude-js@${nextRelease.version}" }], ["@semantic-release/github", { From a467aa351a942cce1b75060e7fd0713ee1b36170 Mon Sep 17 00:00:00 2001 From: John Tran Date: Mon, 21 Sep 2020 21:50:13 -0700 Subject: [PATCH 2/4] Document deploy_s3 --- scripts/deploy_s3.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/deploy_s3.py b/scripts/deploy_s3.py index 7f0556c5..16904fef 100644 --- a/scripts/deploy_s3.py +++ b/scripts/deploy_s3.py @@ -1,3 +1,5 @@ +# Script used by CI to upload snippets to S3 + import argparse import os import sys From 4c6dc313fda2bb2214999c978cb27a52f55d7d05 Mon Sep 17 00:00:00 2001 From: John Tran Date: Mon, 21 Sep 2020 21:50:24 -0700 Subject: [PATCH 3/4] correct test.yml naming --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a2e91173..3625acaa 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -3,7 +3,7 @@ name: Test on: [push, pull_request] jobs: - build: + test: strategy: fail-fast: false matrix: From 8cee2e72e04105ea66871294f48c174e1b0e21bc Mon Sep 17 00:00:00 2001 From: John Tran Date: Mon, 21 Sep 2020 21:50:50 -0700 Subject: [PATCH 4/4] update docs --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d7474acd..a4619f0a 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -4,7 +4,7 @@ on: workflow_dispatch: inputs: dryRun: - description: 'Do a dry run instead of real release' + description: 'Do a dry run to preview instead of a real release' required: true default: 'true'