Skip to content

Conversation

@jarrenpatao
Copy link
Contributor

Summary

This adds a description to the SDK Reference for the setSessionId method

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: NO

/**
* Set a custom Session ID for the current session.
* Note: This is not recommended unless you know what you are doing because the Session ID of a session is utilized for all session metrics in Amplitude.
* The Session ID to set for the current session must be in milliseconds since epoch (Unix Timestamp).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is me just not knowing the exact spec here. Is this req'd or just a suggestion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually what was previously documented in our Help Center. If this is not req'd, then we can definitely edit the text.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know either. I'll ask the dataPL/Query teams

@kelvin-lu kelvin-lu merged commit c47c6f4 into amplitude:master May 28, 2021
kelvin-lu added a commit that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants