From 2d149cc986cff29560dddc9e491eb9923572c1eb Mon Sep 17 00:00:00 2001 From: "justin.fiedler" Date: Thu, 7 Oct 2021 00:22:44 +0000 Subject: [PATCH 1/6] chore: switched to NPM_AUTH_TOKEN for GH packages publish --- .github/workflows/publish-github-packages.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-github-packages.yml b/.github/workflows/publish-github-packages.yml index 6b7c5a23..93fa127d 100644 --- a/.github/workflows/publish-github-packages.yml +++ b/.github/workflows/publish-github-packages.yml @@ -63,6 +63,6 @@ jobs: - name: Publish env: - NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + NPM_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | yarn publish --${{ env.PACKAGE_VERSION }} --tag ${{ env.DIST_TAG }} --no-git-tag-version From 4da23104763c0382ada574546babb1943c3b44ba Mon Sep 17 00:00:00 2001 From: "justin.fiedler" Date: Thu, 7 Oct 2021 00:33:06 +0000 Subject: [PATCH 2/6] chore: switched to Node 12 for GH packages publish workflow --- .github/workflows/publish-github-packages.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publish-github-packages.yml b/.github/workflows/publish-github-packages.yml index 93fa127d..a271eb16 100644 --- a/.github/workflows/publish-github-packages.yml +++ b/.github/workflows/publish-github-packages.yml @@ -33,7 +33,7 @@ jobs: DIST_TAG: ${{ github.event.inputs.distTag }} strategy: matrix: - node-version: [ 14.x ] + node-version: [ 12.x ] steps: - name: Checkout uses: actions/checkout@v2 @@ -62,7 +62,6 @@ jobs: registry-url: 'https://npm.pkg.github.com' - name: Publish + run: yarn publish --${{ env.PACKAGE_VERSION }} --tag ${{ env.DIST_TAG }} --no-git-tag-version env: NPM_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: | - yarn publish --${{ env.PACKAGE_VERSION }} --tag ${{ env.DIST_TAG }} --no-git-tag-version From f44e201465af8e5a4693b555ed43704f4df5c005 Mon Sep 17 00:00:00 2001 From: "justin.fiedler" Date: Thu, 7 Oct 2021 00:49:41 +0000 Subject: [PATCH 3/6] chore: try setting npm registry explicitly --- .github/workflows/publish-github-packages.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/publish-github-packages.yml b/.github/workflows/publish-github-packages.yml index a271eb16..a63f5acc 100644 --- a/.github/workflows/publish-github-packages.yml +++ b/.github/workflows/publish-github-packages.yml @@ -62,6 +62,10 @@ jobs: registry-url: 'https://npm.pkg.github.com' - name: Publish - run: yarn publish --${{ env.PACKAGE_VERSION }} --tag ${{ env.DIST_TAG }} --no-git-tag-version + run: | + cat package.json + yarn config set registry https://npm.pkg.github.com + yarn config list + yarn publish --${{ env.PACKAGE_VERSION }} --tag ${{ env.DIST_TAG }} --no-git-tag-version env: NPM_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 6cdcbec7f6d8637fbd8c9495a45b445ee72bb9ff Mon Sep 17 00:00:00 2001 From: "justin.fiedler" Date: Thu, 7 Oct 2021 01:05:32 +0000 Subject: [PATCH 4/6] chore: set npm registry to include amplitude scope --- .github/workflows/publish-github-packages.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-github-packages.yml b/.github/workflows/publish-github-packages.yml index a63f5acc..e3470b42 100644 --- a/.github/workflows/publish-github-packages.yml +++ b/.github/workflows/publish-github-packages.yml @@ -64,7 +64,7 @@ jobs: - name: Publish run: | cat package.json - yarn config set registry https://npm.pkg.github.com + yarn config set registry https://npm.pkg.github.com/@amplitude yarn config list yarn publish --${{ env.PACKAGE_VERSION }} --tag ${{ env.DIST_TAG }} --no-git-tag-version env: From 6777e73a158cbbb678a76e18d0dc925c830354a2 Mon Sep 17 00:00:00 2001 From: "justin.fiedler" Date: Thu, 7 Oct 2021 01:16:28 +0000 Subject: [PATCH 5/6] chore: convert to scoped package for GH package publishing --- .github/workflows/publish-github-packages.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/publish-github-packages.yml b/.github/workflows/publish-github-packages.yml index e3470b42..f4d2cb50 100644 --- a/.github/workflows/publish-github-packages.yml +++ b/.github/workflows/publish-github-packages.yml @@ -63,9 +63,8 @@ jobs: - name: Publish run: | + sed -i 's,"name": "amplitude-js","name": "@amplitude/amplitude-js",' package.json cat package.json - yarn config set registry https://npm.pkg.github.com/@amplitude - yarn config list yarn publish --${{ env.PACKAGE_VERSION }} --tag ${{ env.DIST_TAG }} --no-git-tag-version env: NPM_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 3b8b2831dfe75a9bf54b5cad364dec932f90c437 Mon Sep 17 00:00:00 2001 From: "justin.fiedler" Date: Thu, 7 Oct 2021 01:22:56 +0000 Subject: [PATCH 6/6] chore: switched back to NODE_AUTH_TOKEN --- .github/workflows/publish-github-packages.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-github-packages.yml b/.github/workflows/publish-github-packages.yml index f4d2cb50..2fd5a65c 100644 --- a/.github/workflows/publish-github-packages.yml +++ b/.github/workflows/publish-github-packages.yml @@ -67,4 +67,4 @@ jobs: cat package.json yarn publish --${{ env.PACKAGE_VERSION }} --tag ${{ env.DIST_TAG }} --no-git-tag-version env: - NPM_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}