Skip to content

fix: do not overwrite flushIntervalMillis=0 with default value (10 seconds) #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2023
Merged

fix: do not overwrite flushIntervalMillis=0 with default value (10 seconds) #377

merged 1 commit into from
Apr 27, 2023

Conversation

@falconandy
Copy link
Contributor

@falconandy falconandy commented Apr 27, 2023

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@falconandy falconandy force-pushed the DXOC-796-flushIntervalMillis-0-uses-default-interval branch from a99c67a to d3025a9 Compare April 27, 2023 15:17
@falconandy falconandy marked this pull request as ready for review April 27, 2023 15:24
@justin-fiedler justin-fiedler merged commit 02dc428 into main Apr 27, 2023
@justin-fiedler justin-fiedler deleted the DXOC-796-flushIntervalMillis-0-uses-default-interval branch April 27, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@justin-fiedler justin-fiedler justin-fiedler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@falconandy @justin-fiedler