From a8e3b39c347789d604eea6265a3701c748cfae94 Mon Sep 17 00:00:00 2001 From: Brian Giori Date: Wed, 2 Apr 2025 08:42:04 -0700 Subject: [PATCH 1/2] fix: include all dist in published package --- packages/experiment-tag/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/experiment-tag/package.json b/packages/experiment-tag/package.json index 4ec98c74..7646b69a 100644 --- a/packages/experiment-tag/package.json +++ b/packages/experiment-tag/package.json @@ -10,6 +10,7 @@ "publishConfig": { "access": "public" }, + "files": ["dist/**/*"], "repository": { "type": "git", "url": "https://github.com/amplitude/experiment-js-client.git", From df1537d3928bcb23ff982b5c6d92679145b19bdf Mon Sep 17 00:00:00 2001 From: Brian Giori Date: Wed, 2 Apr 2025 09:26:15 -0700 Subject: [PATCH 2/2] fix: include exported types --- packages/experiment-tag/package.json | 3 +-- packages/experiment-tag/rollup.config.js | 12 ++++-------- packages/experiment-tag/src/{script.ts => index.ts} | 8 ++++++++ 3 files changed, 13 insertions(+), 10 deletions(-) rename packages/experiment-tag/src/{script.ts => index.ts} (66%) diff --git a/packages/experiment-tag/package.json b/packages/experiment-tag/package.json index 7646b69a..e3d683e7 100644 --- a/packages/experiment-tag/package.json +++ b/packages/experiment-tag/package.json @@ -10,7 +10,6 @@ "publishConfig": { "access": "public" }, - "files": ["dist/**/*"], "repository": { "type": "git", "url": "https://github.com/amplitude/experiment-js-client.git", @@ -36,6 +35,6 @@ "rollup-plugin-license": "^3.6.0" }, "files": [ - "dist" + "dist/**/*" ] } diff --git a/packages/experiment-tag/rollup.config.js b/packages/experiment-tag/rollup.config.js index 4aca40a1..ab3c3a38 100644 --- a/packages/experiment-tag/rollup.config.js +++ b/packages/experiment-tag/rollup.config.js @@ -14,16 +14,11 @@ import license from 'rollup-plugin-license'; import * as packageJson from './package.json'; const getCommonBrowserConfig = (target) => ({ - input: 'src/script.ts', + input: 'src/index.ts', treeshake: { moduleSideEffects: 'no-external', }, plugins: [ - replace({ - preventAssignment: true, - BUILD_BROWSER: true, - 'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV), - }), resolve(), json(), commonjs(), @@ -64,17 +59,18 @@ const getOutputConfig = (outputOptions) => ({ }, }); +const config = getCommonBrowserConfig('es5'); const configs = [ // legacy build for field "main" - ie8, umd, es5 syntax { - ...getCommonBrowserConfig('es5'), + ...config, ...getOutputConfig({ entryFileNames: 'experiment-tag.umd.js', exports: 'named', format: 'umd', }), plugins: [ - ...getCommonBrowserConfig('es5').plugins, + ...config.plugins, terser({ format: { // Don't remove semver comment diff --git a/packages/experiment-tag/src/script.ts b/packages/experiment-tag/src/index.ts similarity index 66% rename from packages/experiment-tag/src/script.ts rename to packages/experiment-tag/src/index.ts index 928a0647..16232a4b 100644 --- a/packages/experiment-tag/src/script.ts +++ b/packages/experiment-tag/src/index.ts @@ -12,3 +12,11 @@ DefaultWebExperimentClient.getInstance(API_KEY, initialFlags, { // Remove anti-flicker css if it exists document.getElementById('amp-exp-css')?.remove(); }); + +export { WebExperimentClient } from 'web-experiment'; +export { WebExperimentConfig } from 'config'; +export { + ApplyVariantsOptions, + RevertVariantsOptions, + PreviewVariantsOptions, +} from 'types';