feat: add setTracksAssignment #56
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new feature to enable tracking assignment events for variant fetching. The implementation includes a new setTrackAssignmentEvent method that allows users to configure whether assignment events should be tracked when fetching variants.
- Introduces
SingleValueStoreCacheclass for persistent storage of options - Adds
setTrackAssignmentEventmethod to control tracking behavior - Updates dependency version to support new tracking options
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/storage/cache.ts | Added SingleValueStoreCache class and getVariantsOptionsStorage factory function for persistent storage |
| src/experimentClient.ts | Integrated tracking options storage and implemented setTrackAssignmentEvent method |
| package.json | Updated @amplitude/experiment-core dependency from 0.7.2 to 0.10.0 |
| tests/client.test.ts | Added comprehensive test coverage for the new tracking assignment functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
📝 Documentation updates detected! New suggestion: Document setTrackAssignmentEvent method for React Native SDK |
zhukaihan
changed the title
| /** | ||
| * Set to track assignment event or not for fetching variants. | ||
| * @param doTrack | ||
| */ | ||
| public async setTracksAssignment(doTrack: boolean): Promise<void> { |
There was a problem hiding this comment.
nit: This could be more concise.
/**
Enables or disables tracking of assignment events when fetching variants.
@param doTrack Whether to track assignment events.
*/
Add
setTracksAssignment.