New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Amp-Sidebar "inline styles" error #1341

Closed
orlov0562 opened this Issue Jul 9, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@orlov0562
Copy link

orlov0562 commented Jul 9, 2018

Hi there,

When I try to run amp-sidebar example, from here or here in Chrome it produce next error in Developers Tools Console:

Inline styles with top, bottom and other CSS rules are not supported yet for fixed or sticky elements (#14186). Unexpected behavior may occur.

Looks like the example doesn't match Chrome AMP requirements (LOL)

Steps to reproduce

  • Open example from here or here in Chrome
  • Open Developers Tools, switch to Console tab
  • Press three times on "Toogle sidebar"

Current behavior

Error: Inline styles with `top`, `bottom` and other CSS rules are not supported yet for fixed or sticky elements (#14186). Unexpected behavior may occur.

image

Expected behavior
No errors

@fstanis

This comment has been minimized.

Copy link
Collaborator

fstanis commented Jul 9, 2018

This warning actually comes from the AMP runtime (specifically here) and it's safe to ignore.

Specifically, it's part of an experiment (#11881) to enable partial support for style attributes. Because <amp-sidebar> gets a style attribute when toggled, this triggers the (false positive) warning.

@fstanis fstanis closed this Jul 9, 2018

@madestroIT

This comment has been minimized.

Copy link

madestroIT commented Sep 19, 2018

This is happening to me as well and it's not just logging errors. It disables the bar after it is hidden. JS errors occur and the sidebar can no longer be shown.

It can be seen here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment