Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let amp-carousel be optional for galleries #1065

Closed
RitaRoca opened this Issue Apr 7, 2018 · 4 comments

Comments

6 participants
@RitaRoca
Copy link

RitaRoca commented Apr 7, 2018

Hi, I see that the plugin converts automatically a Wordpress Gallery into a slider. Can I disable that option to get the normal gallery?

Thanks

@westonruter

This comment has been minimized.

Copy link
Member

westonruter commented Apr 7, 2018

This is something I've noticed that I think needs to change. The gallery output in AMP should be the same as the normal gallery, with opt-in for enhancements such as carousel. Maybe lightbox could be included by default. We can take cues from Jetpack's gallery extensions here.

@westonruter westonruter added this to the v1.0 milestone Apr 18, 2018

@westonruter westonruter changed the title Carrousel WP Galley Let amp-carousel be optional for galleries Apr 18, 2018

@westonruter westonruter added this to Definition in v1.0 Apr 18, 2018

@postphotos postphotos added the Sprint 4 label Apr 19, 2018

@miina miina assigned miina and unassigned miina Apr 26, 2018

@postphotos

This comment has been minimized.

Copy link
Contributor

postphotos commented May 2, 2018

Thanks @RitaRoca - We have this in our backlog as an item to work on and I believe we'll find a decent alternative here. 👍

Reminds me of Should I use a carousel and Yoast's summary on sliders.

@westonruter

This comment has been minimized.

Copy link
Member

westonruter commented May 31, 2018

Fixed in #1121

@westonruter westonruter moved this from In progress to Ready for QA in v1.0 May 31, 2018

@kienstra

This comment has been minimized.

Copy link
Collaborator

kienstra commented Jun 5, 2018

Moving To "Ready For Merging"

The test steps in #1121 should cover this issue.

@kienstra kienstra moved this from Ready for QA to Ready for Merging in v1.0 Jun 5, 2018

@kienstra kienstra moved this from Ready for Merging to In Production in v1.0 Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.